Added "Day of Our Lady of the Rosary of Chiquinquirá" to Colombian holidays#1295
Merged
Conversation
Contributor
|
Hey @alejocas, thanks for your pull request. Can you please add this new public holiday to the tests? |
derTobsch
reviewed
Jun 15, 2026
| <MovingCondition substitute="SATURDAY" with="NEXT" weekday="MONDAY"/> | ||
| <MovingCondition substitute="SUNDAY" with="NEXT" weekday="MONDAY"/> | ||
| </Fixed> | ||
| <Fixed month="JULY" day="9" descriptionPropertiesKey="DAY_OF_OUR_LADY_OF_THE_ROSARY_OF_CHIQUINQUIRA"> |
Contributor
There was a problem hiding this comment.
Please add validFrom="2026"
Contributor
Author
|
Done, added validFrom property and test fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently the Colombian congress passed a law that establishes a new holiday. This PR adds it to the library.
Source: https://colombiaone.com/2026/06/05/colombia-new-annual-public-holiday-in-july/
closes #1301