Testing notifications - Do not merge #1
Draft
focanag wants to merge 635 commits intofocanag:masterfrom
Draft
Conversation
…ion). Updated the version info.
… on Windows and/or systems where you might have the code stored someplace other than in a 'find_orb' directory immediately underneath the home directory.
… observer details.
…boxes (which don't have a '~' = home directory concept), but should remain ~ on other platforms.
… been generalized off-earth, and lunicentric ephems always showed objects as being blocked by the moon.
…our characters long. Reported by Alex Gibbs.
…tion is beyond a 'reasonable' length (same criteria used as for Herget steps)
…ind 'piece' files and didn't unlink temporary files
…as a 'temp' variable elsewhere
…nd nominal_rv variables in debug builds. In non-debug builds, the optimizer recognizes that those variables will inevitably be set, but debug builds skip that procedure. I also realized that 'computer friendly' (high precision) residuals would overflow the buffer if abs(resid)>=10 arcseconds; the text is now truncated correctly, without producing an error.
…pe, instead of a cryptic array of seven doubles. No effect on the output (yet), but it makes the code more readable and will help in future work.
… now shows that date/time in MJD or JD form.
…b had an off-by-one problem. You'd click on a desired obscode, and get a different one instead.
…lly being used to show designations or whatever happened to be in columns 57-65 of the original MPC report. Now labels said column correctly.
…icentric (or any place on the moon), show earth elongation instead.
The Horizons commentary for this quantity specifies that it is positive if the observer is above the orbit plane and negative if below. That means the quantity must flip sign for a retrograde orbit. Odd, but easy to accommodate. Man-To Hui pointed out the error, and also noticed that even after this fix, PlAng for C/2024 S1 (Kreutz sungrazer) differs from Horizons by as much as three degrees. Still investigating this.
…new site in Oklahoma City.
…s definition for that quantity
…should be using that, rather than the text version.
…er-digit-digit one. (Saves minor wear and tear on MPC servers.) Also, if 'cospar.txt' isn't found, abort; don't just keep going with a zero rotation rate for the earth or other body.
MPC just published the new position of Z84 with an updated position (improved lat/long and corrected elevation).
…inties. For correlated RA/dec errors, this shows the uncertainties both in elliptical (major axis, minor axis, and position angle) form, _and_ in ADES form (rmsRA, rmsDec, rmsCorr).
…on and the magnitude, and information about the astrometric uncertainty for that observation will be shown
…ly once upon a time?)
…unately, only mattered in unusual cases involving mixed ADES and 80-column observations of different objects... but I encountered such a case.)
…s were set so as to allow that. Unusual in most systems, but not on Microsoft Windows.
…fferent one for other OSes.
…the distant past?)
…lumn single-character band 'j'. I'm assuming Vj = V for our humble purposes. MPC is, I gather, attempting to sort this out.
…. Fortunately, an edge case very rarely triggered... still, it was wrong.
…nds, it is considered a 'dec only' or 'RA only' observation, of the sort commonly made in the 19th century or earlier. The 'unobserved' axis is omitted on-screen.
…re, and now found in 'constant.h')
…retired. The SWFO-L1 spacecraft now has unofficial code (SWF). There are four new terrestrial codes and two with position tweaks. Also updated the version date.
…onfused into considering only one. Also, there are now six spacecraft that might report sungrazer data.
Ensure attempt_extensions() rewrites covar.json for the final best_orbit and final included-observation set.
Sync covar.json after reverting to best orbit
…ack/arcseconds cross-track', or 'normalized', as appropriate.
…orbital elements display was usually converted from ecliptic to equatorial twice for geocentric elements.
…sure_config_directory_exists().
We had two functions, fix_tilde() and fix_home_dir(), which did almost exactly the same thing : if a file name began with ~, it was replaced with getenv( "HOME"). Further, both broke if that environment pointer was NULL (which, for the server-based 'fo_serve.cgi', it is). fix_tilde() is now gone and the code won't segfault. Also, fo_serve.cgi now explicitly looks for files in its own directory.
If an ADES RA is, say, 314.15, it may mean the RA is good to 0.01 degree. Or it may be that trailing zeroes were omitted. The latter is quite likely, but you could introduce garbage data if the data in question was actually truncated/rounded. 'Losing' a digit that way will presumably happen one time in ten. So 10% of the time, an observation _may_ not be given its full, correct weight in the solution. I think that's better than introducing the occasional junk observation; if I change my mind, I'll enable the currently #ifdef-fed out code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.