Add more naming strategies/formats enum types#30
Open
tomroffe wants to merge 2 commits intofnichol:mainfrom
Open
Add more naming strategies/formats enum types#30tomroffe wants to merge 2 commits intofnichol:mainfrom
tomroffe wants to merge 2 commits intofnichol:mainfrom
Conversation
- Updated regex to `1.10.4` - Updated `CHANGELOG.md` - Added `tests/lib.rs` for naming strategy testing - Added and Updated `READMD.md` and `README.tpl` with new functionaility with examples. - Updated `bin/names.rs` - Updated with new functionality `src/lib.rs` Signed-off-by: Tom Roffe <tom.roffe@gmail.com>
Signed-off-by: Tom Roffe <tom.roffe@gmail.com>
tomroffe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HI 👋,
Please excuse the uninvited PR, but I thought to share just in case someone else found this useful. Please let me know your thoughts on including, and ill be happy to adapt. 😄
I needed the format of the generated names to be slightly different. To allow this, I adapted your code to include functionality from Inflector
0.11.4which manifests itself as newNameenum types in addition toName::PlainandName::Numbered. Specifically:Change Log
src/lib.rs, newNametypesCHANGELOG.mdwith notes on new naming strategy functionalitytests/lib.rsfor naming strategy testingREADMD.mdandREADME.tplwith notes on new functionality with examples.bin/names.rsto reflect breaking changes toGenerator::newtogether with additional CLI-s/--strategyswitch logic.1.10.4[profile.release]section toCargo.toml