Fix: Upgrade stow to fix listing error files#6159
Merged
Merged
Conversation
Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com>
Collaborator
Code Review Agent Run Status
|
Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6159 +/- ##
==========================================
+ Coverage 36.98% 37.02% +0.04%
==========================================
Files 1318 1317 -1
Lines 132449 132523 +74
==========================================
+ Hits 48984 49065 +81
Misses 79212 79212
+ Partials 4253 4246 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com>
Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com>
Collaborator
Code Review Agent Run #19512dActionable Suggestions - 0Review Details
AI Code Review powered by |
Collaborator
Changelist by BitoThis pull request implements the following key changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
For RFC #5598, flytepropeller was given the ability to list error files in the so-called raw output prefix bucket of an execution with the goal of identifying which worker pod in a failed distributed task experienced the first error.
For this purpose, the
StowStorein flytestdlib was given aListfunction.For google cloud storage buckets, the listing and subsequent access of the error files currently does not work: When listing a bucket
gs://some-bucket/..., one receives items in the formgoogle://storage.googleapis.com/download/storage/v1/b/some-bucket/...which then cannot be found by the stow store for thegs://prefix.This was fixed in flyteorg/stow#17. This PR upgrades the stow dependency
Summary by Bito
Dependency upgrade of stow from v0.3.10 to v0.3.11 across Flyte components to resolve GCS bucket listing issues. The update fixes incompatible URL format problems in Google Cloud Storage buckets. This change supports RFC #5598 implementation for improved failure detection in distributed tasks.Unit tests added: False
Estimated effort to review (1-5, lower is better): 3