-
Notifications
You must be signed in to change notification settings - Fork 93
fix(FeatureFlexibleContentExtension): resolve compatibility issues with ACF Pro 6.5.0 #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(FeatureFlexibleContentExtension): resolve compatibility issues with ACF Pro 6.5.0 #609
Conversation
|
@timohubois 👍🏻 I like it - works well for my tests. Visually it might get a bit untidy with the renamed labels in front of the screenshot for some of the components, but let's see how often that would be used anyways. |
|
@aaronmeder and @harunbleech made some minor style improvements: adjusted the spacing inside the pop-up for better readability and ensured that the "no results" state no longer causes layout jumps. Screenshots now overlap again. For the new ACF rename feature, only the renamed title is displayed. This feels more natural and closer to the previous behavior, even though the implementation is a bit hacky and doesn’t fully uses the native ACF behavior. Let me know what you think! |
| display: inline-flex; | ||
| font-size: 0; | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timohubois Maybe you can include the opacity styles here if a component is disabled, from #608.
.layout[data-enabled="0"] {
opacity: 0.4;
&:hover {
.acf-layout-disabled {
opacity: 1;
}
}
}
.layout.active-layout {
&[data-enabled="0"] {
opacity: 1;
}
}|
@timohubois I like the slightly updated look and rename title behaviour - feels good for me! 👍🏻 |
… search for improved accessibility
…improved focus and no results display
…for better layout
|
I can also confirm that the 6.5.1 update broke the changes again because the ACF tooltip element is no longer a child of the
For |
…ure-flexible-content-extension
|
Made some smaller changes again. @arnespremberg and @TheChriZZoW does they work for you as well? |
|
@timohubois Yes, they work for me. But I don't think the improvements were really necessary. |



No description provided.