feat(framework): Enable user-specified include/exclude for FAB build#6805
Merged
danieljanes merged 53 commits intomainfrom Mar 25, 2026
Merged
feat(framework): Enable user-specified include/exclude for FAB build#6805danieljanes merged 53 commits intomainfrom
danieljanes merged 53 commits intomainfrom
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nclude-based-fab-build
…ent-related files
f79f7c0 to
1cb1020
Compare
panh99
reviewed
Mar 24, 2026
panh99
reviewed
Mar 24, 2026
panh99
reviewed
Mar 24, 2026
panh99
reviewed
Mar 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates FAB bundling (flwr build) so that file selection is driven by user-provided [tool.flwr.app].fab-include / fab-exclude patterns (when configured), and then constrained by the built-in FAB include/exclude safeguards. It also standardizes how warnings/notes are emitted for pattern issues and adds tests for the updated behavior.
Changes:
- Remove
.gitignore-based filtering from FAB build; rely on user include/exclude patterns plus built-in constraints. - Add unified warning/note emission for empty lists, unmatched patterns, include/exclude overlap, and built-in constraint removals.
- Add tests validating filtering outcomes and warning output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
framework/py/flwr/cli/build.py |
Reworks FAB path filtering to apply user patterns and built-in constraints; adds consistent warning/note emission. |
framework/py/flwr/cli/build_test.py |
Adds helper and tests for new filtering behavior and warning messages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
panh99
reviewed
Mar 24, 2026
panh99
approved these changes
Mar 25, 2026
danieljanes
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
fab-includeorfab-excludeset to an empty listfab-includepatterns whose matched files are all removed by built-in constraintsfab-includeandfab-excludepatterns overlap,fab-excludepatterns prevail and the matching files are filtered out.KeyErrorfor Windows-style path separators inbuild_fab_from_files: all keys are now normalized to forward slashes up-front, so callers passingsrc\client.py-style keys are handled correctly.Merge after: