Skip to content

All four issues (#427, #441, #443, #474) are fully implemented#525

Merged
floxxih merged 4 commits into
floxxih:masterfrom
JONAH-6:master
May 30, 2026
Merged

All four issues (#427, #441, #443, #474) are fully implemented#525
floxxih merged 4 commits into
floxxih:masterfrom
JONAH-6:master

Conversation

@JONAH-6
Copy link
Copy Markdown
Contributor

@JONAH-6 JONAH-6 commented May 30, 2026

Summary

  • Add Playwright smoke test for happy-path swap form without wallet dependency
  • Cap price history per-asset at 500 entries in addition to the existing global 5000 cap
  • Log and surface an explicit warning when fee estimation is requested for an unsupported chain
  • Run cargo clippy on the relayer in scripts/verify.sh

Changes

frontend/e2e/swap-smoke.spec.ts (new)

Seven smoke tests cover: page heading, From/To selector visibility, default XLM→BTC route, amount input,
disabled submit with no wallet, wallet-connect hint, and submit staying disabled after amount entry.

backend/app/services/price_oracle.py

Added MAX_HISTORY_PER_ASSET = 500 constant. _record_history now prunes per-asset before applying the global
5000 cap.

backend/tests/test_price_oracle.py

New test_per_asset_history_is_bounded verifies pruning removes excess entries for a single asset.

backend/app/services/fee_estimation.py

Added import logging, logger, and warning: Optional[str] = None field on FeeEstimate. Unsupported
chains now log a warning and set estimate.warning with the message "Chain '...' is not supported for fee estimation.".

backend/tests/test_fee_estimation.py

test_estimate_unknown_chain extended to assert warning is set and contains "not supported".

scripts/verify.sh

Added RELAYER_DIR variable and a second clippy block that runs cargo clippy -- -D warnings on the relayer.
set -euo pipefail ensures non-zero exit on clippy failure.

Closes

Closes #427
Closes #441
Closes #443
Closes #474

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 30, 2026

@JONAH-6 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@floxxih floxxih merged commit ccb1e4e into floxxih:master May 30, 2026
13 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants