All four issues (#427, #441, #443, #474) are fully implemented#525
Merged
Conversation
|
@JONAH-6 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo clippyon the relayer inscripts/verify.shChanges
frontend/e2e/swap-smoke.spec.ts(new)Seven smoke tests cover: page heading, From/To selector visibility, default XLM→BTC route, amount input,
disabled submit with no wallet, wallet-connect hint, and submit staying disabled after amount entry.
backend/app/services/price_oracle.pyAdded
MAX_HISTORY_PER_ASSET = 500constant._record_historynow prunes per-asset before applying the global5000 cap.
backend/tests/test_price_oracle.pyNew
test_per_asset_history_is_boundedverifies pruning removes excess entries for a single asset.backend/app/services/fee_estimation.pyAdded
import logging,logger, andwarning: Optional[str] = Nonefield onFeeEstimate. Unsupportedchains now log a warning and set
estimate.warningwith the message"Chain '...' is not supported for fee estimation.".backend/tests/test_fee_estimation.pytest_estimate_unknown_chainextended to assertwarningis set and contains"not supported".scripts/verify.shAdded
RELAYER_DIRvariable and a second clippy block that runscargo clippy -- -D warningson the relayer.set -euo pipefailensures non-zero exit on clippy failure.Closes
Closes #427
Closes #441
Closes #443
Closes #474