Skip to content

Add footprint table mode, bar analysis, and footprint color controls#129

Draft
Niketion wants to merge 5 commits into
flowsurface-rs:mainfrom
Niketion:feat/footprint-table-bar-analysis
Draft

Add footprint table mode, bar analysis, and footprint color controls#129
Niketion wants to merge 5 commits into
flowsurface-rs:mainfrom
Niketion:feat/footprint-table-bar-analysis

Conversation

@Niketion

@Niketion Niketion commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add Table footprint cluster rendering with optional side candle.
  • Add configurable footprint colors for POC, NPoC, and imbalance highlights.
  • Add the Bar Analysis indicator using shared footprint summary calculations.
  • Restrict Bar Analysis to footprint charts only, keeping it unavailable on candlestick charts.
  • Add a shared per-indicator settings model persisted at the pane/layout level, designed for existing and future indicators.
  • Add configurable indicator controls in the indicators modal.
  • Add conditional custom color sections that only appear when custom colors are enabled.
  • Add custom color support for Volume, CVD, and Open Interest, while preserving theme-based defaults when custom colors are disabled.
  • Preserve NPoC configuration when switching to Table mode while hiding unsupported Table rendering/settings.
  • Preserve backward compatibility with existing saved layouts by migrating legacy indicator enums into the new config wrappers.

Validation

  • cargo fmt
  • cargo check
  • cargo clippy --all-targets --all-features -- -D warnings
image image image

@akenshaw

Copy link
Copy Markdown
Member

First of all thanks for this PR @Niketion

Lots of great features and customizability i see, you’re showing the possibility of what can be achieved with this project 👏

However there’s like at least 3-4 PR’s work here; all these features doesn’t fit into this single PR, lots of code changed and modules touched/moved while some of the features are unrelated to these changes.

What i’d like to see would be that if it were separated into at least 3 different PR’s:

  • Table mode
  • Bar analysis indicator
  • Customization(which is why it probably had to touch lots of existing code, and we have to consider about this a bit more for “app theme” purposes)

And i don’t mind if you split them into several more, actually would be even better

Because there are some features/code that i’d like to improve or change upon, but there also ones that i can keep completely as is of your work, and keep in mind that i still have to manually go through and understand every single line of code i have to merge. So the more we can keep the scopes tight on each PR the cleaner the work would be.

Thanks again ❤️

@Niketion

Copy link
Copy Markdown
Contributor Author

First of all thanks for this PR @Niketion

Lots of great features and customizability i see, you’re showing the possibility of what can be achieved with this project 👏

However there’s like at least 3-4 PR’s work here; all these features doesn’t fit into this single PR, lots of code changed and modules touched/moved while some of the features are unrelated to these changes.

What i’d like to see would be that if it were separated into at least 3 different PR’s:

  • Table mode
  • Bar analysis indicator
  • Customization(which is why it probably had to touch lots of existing code, and we have to consider about this a bit more for “app theme” purposes)

And i don’t mind if you split them into several more, actually would be even better

Because there are some features/code that i’d like to improve or change upon, but there also ones that i can keep completely as is of your work, and keep in mind that i still have to manually go through and understand every single line of code i have to merge. So the more we can keep the scopes tight on each PR the cleaner the work would be.

Thanks again ❤️

I analyzed the split and the cleanest path seems to be a stacked PR sequence, because Table mode and Bar Analysis both depend on shared foundation work

I’ll start with a very small independent bugfix PR, then open a foundation PR for indicator config/settings, then shared FootprintSummary, and finally the feature PRs on top

@Niketion Niketion marked this pull request as draft June 27, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants