Add footprint table mode, bar analysis, and footprint color controls#129
Add footprint table mode, bar analysis, and footprint color controls#129Niketion wants to merge 5 commits into
Conversation
|
First of all thanks for this PR @Niketion Lots of great features and customizability i see, you’re showing the possibility of what can be achieved with this project 👏 However there’s like at least 3-4 PR’s work here; all these features doesn’t fit into this single PR, lots of code changed and modules touched/moved while some of the features are unrelated to these changes. What i’d like to see would be that if it were separated into at least 3 different PR’s:
And i don’t mind if you split them into several more, actually would be even better Because there are some features/code that i’d like to improve or change upon, but there also ones that i can keep completely as is of your work, and keep in mind that i still have to manually go through and understand every single line of code i have to merge. So the more we can keep the scopes tight on each PR the cleaner the work would be. Thanks again ❤️ |
I analyzed the split and the cleanest path seems to be a stacked PR sequence, because Table mode and Bar Analysis both depend on shared foundation work I’ll start with a very small independent bugfix PR, then open a foundation PR for indicator config/settings, then shared FootprintSummary, and finally the feature PRs on top |
Summary
Validation