Skip to content

refactor(tenant): update firstName and lastName types to allow null v…#223

Merged
odinellefsen merged 2 commits intomainfrom
fix-tenant-list-command-output
May 5, 2026
Merged

refactor(tenant): update firstName and lastName types to allow null v…#223
odinellefsen merged 2 commits intomainfrom
fix-tenant-list-command-output

Conversation

@odinellefsen
Copy link
Copy Markdown
Contributor

@odinellefsen odinellefsen commented May 5, 2026

…alues

Summary by CodeRabbit

  • Bug Fixes
    • User profile requirements have been updated to make first and last name fields optional. Users can now create and manage accounts without providing these details, offering greater flexibility and supporting scenarios where name information may not be immediately available.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

Warning

Rate limit exceeded

@odinellefsen has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 57 minutes and 30 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dd45eceb-9c9c-4d7f-b977-193db55c7b35

📥 Commits

Reviewing files that changed from the base of the PR and between 7ae5aac and 20fb2d0.

📒 Files selected for processing (1)
  • src/contracts/tenant.ts
📝 Walkthrough

Walkthrough

TenantUserSchema and the derived TenantUser type are updated to accept firstName and lastName as nullable strings (string | null) instead of required non-null strings, allowing name fields to be absent or null.

Changes

Tenant User Schema Nullability

Layer / File(s) Summary
Data Shape
src/contracts/tenant.ts
TenantUserSchema fields firstName and lastName changed from Type.String() to Type.Union([Type.String(), Type.Null()]). Derived TenantUser type reflects the nullability change.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A name need not be set in stone,
null values find a home,
firstName, lastName now can rest,
with flexible grace, they pass the test!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'refactor(tenant): update firstName and lastName types to allow null values' accurately describes the main change—making firstName and lastName nullable in the TenantUserSchema and TenantUser type.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-tenant-list-command-output

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@odinellefsen odinellefsen merged commit 67d842e into main May 5, 2026
2 checks passed
@odinellefsen odinellefsen deleted the fix-tenant-list-command-output branch May 5, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant