Restructure IR channel emitter into Sender/Listener interfaces#679
Merged
Conversation
Change the channel converter to emit an object/namespace named after the channel that implements Wirespec.Channel and contains two nested interfaces: a Sender with a send method taking the message, and a Listener with a method taking a callback handler for the message. The Java emitter's channel transform is updated accordingly: the @FunctionalInterface wrapping (which assumed a single top-level interface) is dropped, and reference qualification for the name-collision case now covers all custom types in the nested interfaces, including the Listener's function-type handler parameter. Regenerated channel fixtures for all six target languages. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015SorifLsgVZF7pcKV2Zn5g
Interfaces with a single non-generic abstract method (and no abstract properties) are now emitted as functional (fun) interfaces in the Kotlin generator. Generic abstract methods are excluded because a lambda cannot satisfy a generic SAM. Regenerated affected Kotlin fixtures (channel Sender/Listener, endpoint Call, and the shared Wirespec Shape/Transportation interfaces). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015SorifLsgVZF7pcKV2Zn5g
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the channel converter to emit an object/namespace named after the
channel that implements Wirespec.Channel and contains two nested
interfaces: a Sender with a send method taking the message, and a
Listener with a method taking a callback handler for the message.
The Java emitter's channel transform is updated accordingly: the
@FunctionalInterface wrapping (which assumed a single top-level
interface) is dropped, and reference qualification for the
name-collision case now covers all custom types in the nested
interfaces, including the Listener's function-type handler parameter.
Regenerated channel fixtures for all six target languages.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_015SorifLsgVZF7pcKV2Zn5g