Add config to disable the Fully Enable button#979
Merged
jnunemaker merged 4 commits intomainfrom Feb 26, 2026
Merged
Conversation
Collapse two config options (fully_enable_disabled, fully_enable_disabled_with) into a single disable_fully_enable option that accepts true for a default message or a string for a custom message. Update 403 template to use the configured message instead of hardcoding. Add note about UI config test pattern to CLAUDE.md. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move DEFAULT_DISABLE_FULLY_ENABLE_MESSAGE constant next to other constants. Rename template from fully_enable_disabled.erb to disable_fully_enable.erb for naming consistency. Add test for explicit false value. XSS is a non-issue: Erubi escape: true auto-escapes <%= %> output. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disable_fully_enableconfig option toFlipper::UIthat prevents full-enabling features from the web UItrue(default message), a string (custom message), ornil/false(enabled, the default)fully_enable_disabled/fully_enable_disabled_with, collapsed to single config option, 403 template uses configured messageUsage
Note: This only affects the UI. If flipper-api is mounted, full enable is still possible via the API.
Test plan
disable_fully_enable_messagereturns default message fortrue, custom string when setfalsedoes not block enablingCloses #973
🤖 Generated with Claude Code