Skip to content

Use Flathub submodules for SDL2 and Libdecor#22

Open
orowith2os wants to merge 2 commits intoflathub:masterfrom
orowith2os:shared-modules-for-libdecor-and-sdl
Open

Use Flathub submodules for SDL2 and Libdecor#22
orowith2os wants to merge 2 commits intoflathub:masterfrom
orowith2os:shared-modules-for-libdecor-and-sdl

Conversation

@orowith2os
Copy link

Makes the build process quite a bit cleaner.

Also, does it make sense for Moonlight to still build ffmpeg manually? can it not use the ffmpeg extension(s) provided by Flathub?

CC (?) @cgutman

@flathubbot
Copy link

Started test build 10637

@flathubbot
Copy link

Build 10637 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/123089/com.moonlight_stream.Moonlight.flatpakref

@flathubbot
Copy link

Started test build 10769

@flathubbot
Copy link

Build 10769 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/123223/com.moonlight_stream.Moonlight.flatpakref

@cgutman
Copy link
Collaborator

cgutman commented Mar 18, 2023

@orowith2os Is the intention to keep bumping that shared-module to match the latest SDL2 series release? Are you sticking with 2.26.x patches or will you bump to 2.28.x when it releases?

Being such a complex SDL2-based application, Moonlight tends to run into issues that require fixes from bleeding-edge SDL2 commits (things like new APIs, controller compatibility fixes, Wayland fixes, window management fixes, etc). I think 2.26.x is fine for us now, but it's possible we may have to go back to building ourselves if we run into issues like that again.

Also, does it make sense for Moonlight to still build ffmpeg manually? can it not use the ffmpeg extension(s) provided by Flathub?

Yes, I think it still makes sense to build it ourselves. We have non-upstreamed patches that we carry in our fork and the FFmpeg-full extension doesn't have AV1 or NVDEC enabled.

@orowith2os
Copy link
Author

The main modules were already bumped to the latest SDL2 version, iirc, so I'll update this PR for that. Considering SDL3 is currently being developed, I don't think SDL2 will be getting much action anyways.

@cgutman
Copy link
Collaborator

cgutman commented Mar 19, 2023

The main modules were already bumped to the latest SDL2 version, iirc, so I'll update this PR for that.

OK, thanks. I'll merge once it's updated.

Considering SDL3 is currently being developed, I don't think SDL2 will be getting much action anyways.

It's still pretty active for bugfixes: https://github.com/libsdl-org/SDL/commits/SDL2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants