This repository was archived by the owner on Nov 27, 2024. It is now read-only.
Add Ironbank#297
Open
matthewg49 wants to merge 8 commits into
Open
Conversation
Author
|
Testing has ran successfully! PR is ready for review |
gheise
reviewed
May 9, 2022
Contributor
There was a problem hiding this comment.
Hey! Awesome to see this PR, great initiative! Would be great to see more tests, covering different cases (multiple liquidation calls in one tx, reverting, etc.) If possible, run ./mev backfill n m where m >> n, and see if the number of liquidations found is similar to what is expected in that block range and there is an absence of errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds Ironbank liquidations to mev-inspect-py. C.R.E.A.M, in partnership with Yearn, created a lending market that introduces protocol-to-protocol lending while continuing to offer the same services that C.R.E.A.M initially offered. More details on the partnership and launch can be found here.. Ironbank's contracts are all forks of Compounds contracts making the implementation relatively straightforward.
Currently, Ironbank is the third largest lending platform on Ethereum by TVL according to Defillama.
Testing
This is where I am having some issues. I created tests for Ironbank that examines a liquidation transaction, but locally I'm having some issues running the tests. For some reason, my adjustments to
mev_inspect/classifiers/specs/__init__.pybreaks compound, cream and ironbank tests. I have a strong feeling it's my local environment (Windows using WSL2).The reason being is that after I added all of my code changes and ran
./mev inspecton the block that contained the ironbank liquidation, it successfully added an ironbank liquidation to the postgres db!Checklist before merging
./mev testThis is my first contribution to an open source project, so any and all feedback is appreciated. I'm a data scientist by trade so I may have missed a handful of common best practices that are typically followed when contributing.