[wip] [mentions] feat: tag mentions

[imorland]

Implements Bounty proposal
Fixes: #3693

TODO:
[ ] #3620 Modify tag changed eventposts to mention the tags
[ ] Major cleanup
[ ] Add backend tests

Changes proposed in this pull request:

• deprecated getMentionText in favour of a new MentionTextGenerator

Reviewers should focus on:

Screenshot
Early version (will likely change a few times yet)

Necessity

• Has the problem that is being solved here been clearly explained?
• If applicable, have various options for solving this problem been considered?
• For core PRs, does this need to be in core, or could it be in an extension?
• Are we willing to maintain this for years / potentially forever?

Confirmed

• Frontend changes: tested on a local Flarum installation.
• Backend changes: tests are green (run composer test).
• Core developer confirmed locally this works as intended.
• Tests have been added, or are not appropriate here.

Required changes:

• Related documentation PR: (Remove if irrelevant)
• Related core extension PRs: (Remove if irrelevant)

[Ornanovitch]

Just a few remarks considering #3653 and the logic introduced with #3652

[Ornanovitch]

There is a little confusion here, it should be the contrary :)
Cf. #3653

Suggested change

	tag.setAttribute('class', isDark(tagModel.color()) ? 'TagMention--light' : 'TagMention--dark');
	tag.setAttribute('class', isDark(tagModel.color()) ? 'TagMention--dark' : 'TagMention--light');

[imorland]

In actual usage, I've found the opposite. See my dev forum for a live version of this..

[Ornanovitch]

I know it's working perfectly well, this is not a dev problem I suppose. ✌️

What I meant is just that the semantical logic of isDark usage is (according to me) to ask is this a dark color ?, and if it's true, to apply the text-on-dark rule. Adding a --light suffix for a dark element class (or the opposite) sounds counterintuitive IMHO. This could lead to an issue of consistency about the usage of this isDark utility across the project

But maybe there is something I don't understand in your case, I'll try to test your branch!

[Ornanovitch]

Maybe it would be simpler to think about all this with #3653 merged. We could then try to find a homogeneous and common way of operating with those contrast issues :)

[Ornanovitch]

following my previous comment

Suggested change

	color: @text-on-dark;
	color: @text-on-light;

[Ornanovitch]

and so on

Suggested change

	color: @text-on-light;
	color: @text-on-dark;

[SychO9]

See #3769