Fixed stripslashes_deep() call so that it doesn't strip the slashes from the $_FILES array, which will mangle paths on windows filesystems.#51
Open
Vex wants to merge 3 commits intofl4p:masterfrom
Open
Conversation
Removed stripslashes_deep() call from $_FILES superglobal to ensure pathnames for temporary files don't get mangled on windows servers.
Removed stripslashes_deep() call from $_FILES superglobal to ensure pathnames for temporary files don't get mangled on windows servers.
Removed stripslashes_deep() call from $_FILES superglobal to ensure pathnames for temporary files don't get mangled on windows servers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On windows server's the
$_FILESarray contains the path to the file, with slashes '', these slashes get removed by thestripslashes_deep()call, which makes the path to the file meaningless, and results in the plugin being unable to upload the file.