This repository was archived by the owner on Jan 20, 2026. It is now read-only.
Bugfix/add credit card txn transfer exchange rates#72
Merged
fivetran-avinash merged 10 commits intoSep 11, 2025
Conversation
fivetran-joemarkiewicz
suggested changes
Sep 11, 2025
Contributor
fivetran-joemarkiewicz
left a comment
fivetran-joemarkiewicz
left a comment
There was a problem hiding this comment.
A few small change requests before approval.
Comment on lines
+12
to
+15
| ## Bug Fixes | ||
| - Added currency and exchange rate fields for transfers and credit card payment transactions to complete support for Quickbooks multicurrency. | ||
| - This will ensure accurate calculations in the downstream transform `quickbooks__general_ledger` model for multicurrency accounts leveraging these transactions. [See the v0.21.1 release of `dbt_quickbooks` for more details](https://github.com/fivetran/dbt_quickbooks/releases/tag/v0.21.1). | ||
|
|
Contributor
There was a problem hiding this comment.
I would say we don't need this section. I would instead say let's consolidate this information in the Notes section of the schema updates table as right now they are a bit duplicative.
Contributor
Author
There was a problem hiding this comment.
Consolidated.
Comment on lines
+650
to
+675
| - name: stg_quickbooks__invoice_tax_line | ||
| description: "{{ doc('invoice_tax_line_table') }}" | ||
| columns: | ||
| - name: invoice_id | ||
| description: "{{ doc('id') }} invoice associated with this tax line." | ||
| tests: | ||
| - not_null | ||
| - name: index | ||
| description: "{{ doc('tax_index') }} invoice." | ||
| tests: | ||
| - not_null | ||
| - name: tax_rate_id | ||
| description: "{{ doc('tax_rate_id') }}" | ||
| - name: amount | ||
| description: "{{ doc('tax_amount') }}" | ||
| - name: tax_percent | ||
| description: "{{ doc('tax_percent') }}" | ||
| - name: net_amount_taxable | ||
| description: "{{ doc('net_amount_taxable') }} invoice line amount." | ||
| - name: override_delta_amount | ||
| description: "{{ doc('override_delta_amount') }}" | ||
| - name: percent_based | ||
| description: "{{ doc('percent_based') }}" | ||
| - name: tax_inclusive_amount | ||
| description: "{{ doc('tax_inclusive_amount') }}" | ||
|
|
Contributor
There was a problem hiding this comment.
I assume this was a left over from the tax lines branch. We shouldn't include these updates in this release. Please remove the tax table docs.
Contributor
Author
There was a problem hiding this comment.
Ack. Removed.
…ttps://github.com/fivetran/dbt_quickbooks_source into bugfix/add-credit-card-txn-transfer-exchange-rates
Contributor
Author
There was a problem hiding this comment.
@fivetran-joemarkiewicz Ready for re-review!
fivetran-avinash
added
docs:ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
Submission Checklist
Changelog