Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Feature/add all tax lines#66

Closed
fivetran-avinash wants to merge 34 commits into
mainfrom
feature/add-all-tax-lines
Closed

Feature/add all tax lines#66
fivetran-avinash wants to merge 34 commits into
mainfrom
feature/add-all-tax-lines

Conversation

@fivetran-avinash
Copy link
Copy Markdown
Contributor

@fivetran-avinash fivetran-avinash commented Jul 16, 2025

PR Overview

Package version introduced in this PR:

  • 0.15.0-a1

This PR addresses the following Issue/Feature(s):

Summary of changes:

  • Adding tax line models

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • [NA] Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-avinash fivetran-avinash self-assigned this Jul 29, 2025
@fivetran-avinash fivetran-avinash marked this pull request as ready for review July 31, 2025 03:41
Copy link
Copy Markdown
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-avinash thanks for combining these updates! A few comments before approving.

Comment thread integration_tests/dbt_project.yml Outdated
Comment thread dbt_project.yml Outdated
Comment thread integration_tests/dbt_project.yml Outdated
@fivetran-avinash fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Aug 5, 2025
Copy link
Copy Markdown
Contributor Author

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-joemarkiewicz Changes applied and ready for re-review.

Copy link
Copy Markdown
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to go for pre-release once the transform is already ready. I have a few comments that aren't blocking.

I will hold off formally approving until this has been further validated after pre-release.

Comment thread integration_tests/dbt_project.yml Outdated
@fivetran-avinash fivetran-avinash added the docs:ready Triggers the docs generator workflow. label Aug 6, 2025
@fivetran-avinash fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Aug 6, 2025
@fivetran-avinash fivetran-avinash added the pre-release Triggers the auto-releaser workflow. label Aug 12, 2025
@fivetran-avinash fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. pre-release Triggers the auto-releaser workflow. labels Aug 28, 2025
@fivetran-avinash fivetran-avinash added the pre-release Triggers the auto-releaser workflow. label Aug 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

docs:ready Triggers the docs generator workflow. pre-release Triggers the auto-releaser workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants