Skip to content

bugfix/remove_null_team_from_sprint_enhanced#178

Open
fivetran-savage wants to merge 12 commits into
mainfrom
bugfix/remove_null_team_from_sprint_enhanced
Open

bugfix/remove_null_team_from_sprint_enhanced#178
fivetran-savage wants to merge 12 commits into
mainfrom
bugfix/remove_null_team_from_sprint_enhanced

Conversation

@fivetran-savage
Copy link
Copy Markdown
Contributor

PR Overview

Package version introduced in this PR:

  • 1.8.0-a1

This PR addresses the following Issue/Feature(s):

  • GA-1020303

Summary of changes:

  • Fixes null row creation for team if there was ever a null team value for an issue within a sprint.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-savage fivetran-savage marked this pull request as ready for review April 2, 2026 18:14
@fivetran-savage fivetran-savage self-assigned this Apr 2, 2026
@fivetran-savage fivetran-savage added docs:ready Triggers the docs generator workflow. pre-release Triggers the auto-releaser workflow. labels Apr 2, 2026
Copy link
Copy Markdown
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-savage left some notes before approving a pre-release

Comment thread integration_tests/dbt_project.yml Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md
[PR #177](https://github.com/fivetran/dbt_jira/pull/177) includes the following updates:

## Bug Fix
- Updates `jira__sprint_enhanced` to resolve the team per issue per sprint when `jira_using_teams` is enabled. Previously, if an issue had no team assigned at any point during the sprint, the team would appear as null even if a team was later assigned. An additional row would also be created if an issue moved from one team to another within a sprint, causing potential double counting. Now, the model selects the most recent non-null team for each issue-sprint combination, ensuring team assignments are correctly reflected in sprint metrics.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a schema/data breaking change? The data values for team will change for customers upgrading. We should create that section.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't totally sure whether to classify this as a bugfix or feature update. It will change row counts for some but not others, depending on how they set up their Jira instance and whether they have teams enabled. Definitely want to discuss further if/when this becomes a full release but don't think a changelog entry needs to hold up a pre-release.

Comment thread models/jira__sprint_enhanced.sql Outdated
Comment thread README.md
| [jira__project_enhanced](https://fivetran.github.io/dbt_jira/#!/model/model.jira.jira__project_enhanced) | One row per project with team member details, issue counts, work velocity metrics, and project scope information. <br><br>**Example Analytics Questions:**<br><ul><li>Which projects have the highest velocity in terms of issues closed per sprint?</li><li>What is the ratio of unassigned open tickets to assigned open tickets by project?</li></ul> |
| [jira__user_enhanced](https://fivetran.github.io/dbt_jira/#!/model/model.jira.jira__user_enhanced) | One row per user with metrics on open and completed issues, and individual work velocity. <br><br>**Example Analytics Questions:**<br><ul><li>Who are the top performers in terms of issues resolved per month?</li><li>Which team members have the highest workload based on open issue count and how long, on average, have those issues been open?</li></ul> |
| [jira__sprint_enhanced](https://fivetran.github.io/dbt_jira/#!/model/model.jira.jira__sprint_enhanced) | One row per sprint with metrics on issues created, resolved, and carried over, plus story point estimates. <br><br>**Example Analytics Questions:**<br><ul><li>Which sprints had the highest velocity and what made them successful?</li><li>How many story points were planned vs. completed across recent sprints?</li><li>What percentage of issues are typically carried over from sprint to sprint?</li></ul> |
| [jira__sprint_enhanced](https://fivetran.github.io/dbt_jira/#!/model/model.jira.jira__sprint_enhanced) | One row per sprint with metrics on issues created, resolved, and carried over, plus story point estimates. If teams are enabled, granularity is one row per team per sprint. <br><br>**Example Analytics Questions:**<br><ul><li>Which sprints had the highest velocity and what made them successful?</li><li>How many story points were planned vs. completed across recent sprints?</li><li>What percentage of issues are typically carried over from sprint to sprint?</li></ul> |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the yml description as well? Will need to regen docs afterward

@fivetran-savage fivetran-savage added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow. pre-release Triggers the auto-releaser workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants