Add geo reports by fivetran-jamie · Pull Request #44 · fivetran/dbt_facebook_ads_source

fivetran-jamie · 2025-04-23T19:26:09Z

PR Overview

Package version introduced in this PR:
v0.9.0

This PR addresses the following Issue/Feature(s):

GA-926126

Summary of changes:

Adds source tables necessary to create country and region reports downstream

Submission Checklist

Alignment meeting with the reviewer (if needed)
- Timeline and validation requirements discussed
Provide validation details:
- Validation Steps: See transform PR
- Testing Instructions: Will share dataset to use in Height
- Focus Areas: Confirming that variables work as intended

see transform PR for more details, but confirming that the enable/disable variables work:
False produces 16 models

and 20 tests

True produces 24 models

and 24 tests

Changelog

Draft changelog for PR
Final changelog for release review

…ource into feature-update/add-geo-reports

fivetran-joemarkiewicz

LGTM with just a few small suggestions

fivetran-joemarkiewicz · 2025-04-28T16:05:29Z

+        _fivetran_id as country_id,
+        country,
+        date as date_day,
+        cast(account_id as {{ dbt.type_bigint() }}) as account_id,


No necessary to change for this PR since I know this decision was made in other models and we need to conform with the approach. However, it's interesting we make the decision to cast these IDs as integers. Usually we cast as string to be safe.

Yeah I thought so too

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

fivetran-avinash · 2025-04-29T00:31:35Z

            description: Currency associated with account.
          - name: timezone_name
            description: Timezone associated with account.
+          - name: business_country_code


This is a duplicate of lines 31-32, you can remove this.

fivetran-avinash · 2025-04-29T00:37:45Z

+          - name: inline_link_click_ctr
+            description: '{{ doc("inline_link_click_ctr") }}'


Don't see this field in the macro either.

fivetran-avinash · 2025-04-29T00:38:16Z

+          - name: cost_per_inline_link_click
+            description: '{{ doc("cost_per_inline_link_click") }}'
+          - name: cpc
+            description: '{{ doc("cpc") }}'
+          - name: cpm
+            description: '{{ doc("cpm") }}'
+          - name: ctr
+            description: '{{ doc("ctr") }}'


I don't see these fields in the macro, should these be removed?

They're not, but I thought it was easy enough to document them for users in case they want to pass them in. I prefer to leave them in unless you have a strong opinion otherwise

Fair enough!

fivetran-avinash · 2025-04-29T00:39:54Z

+**9 total changes • 0 possible breaking changes**
+| **Data Model** | **Change type** | **Old name** | **New name** | **Notes** |
+| ---------------- | --------------- | ------------ | ------------ | --------- |
+| stg_facebook_ads__demographics_country | New Model |   |   |  Uses `demographics_country` source table  |


Request to add links to the DAG for all Data Model column entries.

fivetran-avinash · 2025-04-29T02:06:11Z


 To connect your multiple schema/database sources to the package models, follow the steps outlined in the [Union Data Defined Sources Configuration](https://github.com/fivetran/dbt_fivetran_utils/tree/releases/v0.4.latest#union_data-source) section of the Fivetran Utils documentation for the union_data macro. This will ensure a proper configuration and correct visualization of connections in the DAG.

+#### Eanble or Disable Country and Region Reports


Suggested change

#### Eanble or Disable Country and Region Reports

#### Enable or Disable Country and Region Reports

Adjusting myself directly

fivetran-avinash · 2025-04-29T02:20:34Z

+          - name: inline
+            description: '{{ doc("inline") }}'
+          - name: _7_d_click
+            description: '{{ doc("_7_d_click") }}'
+          - name: _1_d_view
+            description: '{{ doc("_1_d_view") }}'


Don't see these fields in the macro, should they be removed?

fivetran-avinash · 2025-04-29T02:23:39Z

+          - name: cost_per_inline_link_click
+            description: '{{ doc("cost_per_inline_link_click") }}'
+          - name: cpc
+            description: '{{ doc("cpc") }}'
+          - name: cpm
+            description: '{{ doc("cpm") }}'
+          - name: ctr
+            description: '{{ doc("ctr") }}'


Don't see these fields in the macro, should they be removed?

fivetran-avinash · 2025-04-29T02:23:50Z

+            description: '{{ doc("frequency") }}'
+          - name: spend
+            description: '{{ doc("spend") }}'
+          - name: inline_link_click_ctr


Don't see this field either.

fivetran-avinash · 2025-04-29T02:24:16Z

+            description: '{{ doc("conversions") }}'
+          - name: _fivetran_synced
+            description: '{{ doc("_fivetran_synced") }}'
+          - name: inline


Don't see this field in the corresponding macro.

fivetran-avinash · 2025-04-29T02:37:16Z

+
+## Feature Updates:
+- Added the `facebook_ads__using_demographics_country` and `facebook_ads__using_demographics_region` variables, which can be used to enable or disable the above transformations related to the `demographics_country`/`demograhics_country_actions` and `demographics_region`/`demographics_region_actions` tables.
+  - These variables are dynamically set for Fivetran Quickstart users, but **false** by default otherwise. See [README](https://github.com/fivetran/dbt_facebook_ads_source?tab=readme-ov-file#enable-or-disable-country-and-region-reports) for more details.


Suggested change

- These variables are dynamically set for Fivetran Quickstart users, but **false** by default otherwise. See [README](https://github.com/fivetran/dbt_facebook_ads_source?tab=readme-ov-file#enable-or-disable-country-and-region-reports) for more details.

- These variables are dynamically set for Fivetran Quickstart users, but **false** by default otherwise. See [README](https://github.com/fivetran/dbt_facebook_ads_source?tab=readme-ov-file#enable-or-disable-country-and-region-reports) for more details on how to enable these models, particularly if you are using dbt Core.

Adjusting myself directly

fivetran-avinash

@fivetran-jamie Thanks for applying the updates, lgtm!

fivetran-jamie added 14 commits March 7, 2025 14:07

try out in bk

8352db2

using bq information schema

3ed68d2

use adapter instead of info schema

1154285

polishes

30a45dd

updat license

070e016

license in changelog

88f0391

extra target conditional

434fd31

regen docs

79c830e

Merge branch 'main' of https://github.com/fivetran/dbt_facebook_ads_s…

3d266bb

…ource into feature-update/add-geo-reports

staging

a259dff

update var name,

3de16c2

working

ed3fc42

seed data

f5d3658

polishes

b72471a

fivetran-jamie self-assigned this Apr 23, 2025

fivetran-jamie added 3 commits April 23, 2025 12:31

bk

d0cc8ee

polishes

87fec26

Docs

88f48b0

fivetran-jamie requested a review from fivetran-joemarkiewicz April 24, 2025 16:28

docs

570b900

fivetran-jamie marked this pull request as ready for review April 24, 2025 16:55

fivetran-joemarkiewicz approved these changes Apr 28, 2025

View reviewed changes

fivetran-jamie and others added 3 commits April 28, 2025 13:17

Apply suggestions from code review

eac6df7

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

docs

1d7bbca

correct changelog

43b6eb3

fivetran-avinash reviewed Apr 29, 2025

View reviewed changes

fivetran-jamie added 3 commits April 29, 2025 08:57

Avinash feedback

37dd2ab

dbt-snowflake

4085cc2

docs

b172891

fivetran-avinash approved these changes Apr 29, 2025

View reviewed changes

fivetran-jamie merged commit 69ecea0 into main Apr 29, 2025
8 checks passed

		- name: inline_link_click_ctr
		description: '{{ doc("inline_link_click_ctr") }}'


		To connect your multiple schema/database sources to the package models, follow the steps outlined in the [Union Data Defined Sources Configuration](https://github.com/fivetran/dbt_fivetran_utils/tree/releases/v0.4.latest#union_data-source) section of the Fivetran Utils documentation for the union_data macro. This will ensure a proper configuration and correct visualization of connections in the DAG.

		#### Eanble or Disable Country and Region Reports

	#### Eanble or Disable Country and Region Reports
	#### Enable or Disable Country and Region Reports

	- These variables are dynamically set for Fivetran Quickstart users, but false by default otherwise. See [README](https://github.com/fivetran/dbt_facebook_ads_source?tab=readme-ov-file#enable-or-disable-country-and-region-reports) for more details.
	- These variables are dynamically set for Fivetran Quickstart users, but false by default otherwise. See [README](https://github.com/fivetran/dbt_facebook_ads_source?tab=readme-ov-file#enable-or-disable-country-and-region-reports) for more details on how to enable these models, particularly if you are using dbt Core.

Conversation

fivetran-jamie commented Apr 23, 2025 • edited by fivetran-github-worker Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Overview

Submission Checklist

Changelog

Uh oh!

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fivetran-jamie commented Apr 23, 2025 •

edited by fivetran-github-worker

Loading

fivetran-avinash Apr 29, 2025 •

edited

Loading

fivetran-avinash Apr 29, 2025 •

edited

Loading