Remove stream notifications and add streamer notifications #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karolk99
force-pushed
the
fishjam-livestreams-update
branch
from
3bf85b0 to
0d94acb
Compare
Comment on lines
151
to
160
| // Notification sent when streamer successfully connects | ||
| message StreamConnected { | ||
| string stream_id = 1; | ||
| } | ||
|
|
||
| // Notification sent when streamer disconnects | ||
| message StreamDisconnected { | ||
| string stream_id = 1; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
suggestion: I think we should only mark them as deprecated and remove them in the future
AHGIJMKLKKZNPJKQR
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.