chore(LIB-2651): dependency-security cleanup + prod audit gate#399
Draft
Trebh wants to merge 1 commit into
Draft
chore(LIB-2651): dependency-security cleanup + prod audit gate#399Trebh wants to merge 1 commit into
Trebh wants to merge 1 commit into
Conversation
…n system) The published (production) dependency surface is what reaches consuming apps; the dev/build tooling does not. This makes the prod surface clean + enforced and trims the cheap dev-tooling criticals. - pnpm.overrides: patch the prod-reachable picomatch ReDoS (GHSA-c2c7-rcm5-vvqj) in both the 2.x and 4.x ranges (via tailwindcss>sucrase>tinyglobby), staying within-major; plus handlebars >=4.7.9 and shell-quote >=1.8.4 (dev criticals). - vitest 4.1.1 -> 4.1.6 (root) for the @vitest/browser advisory. - 'pnpm audit --prod --audit-level high' now passes (0 high/critical in prod; 2 moderate remain, below the gate). Enforced via the husky pre-push hook (skippable: SKIP_AUDIT_CHECK=1) AND .github/workflows/audit.yml (the real required check — the repo had no CI and the local hook is skippable). - align .nvmrc (20.11.0) with engines.node (^22.12.0) -> 22.12.0. - renovate.json for grouped low-noise updates (@awesome.me Pro kit excluded). Deferred to backlog (dev-only, do not propagate to consumers): the EOL Storybook babel-traverse chain (no upstream fix) and modernizing packages/card-list's toolchain (vite 5 / plugin-vue 4 / vitest 1 — a bump that drags a full modernization, not a safe override). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: pnpm/action-setup@v4 |
There was a problem hiding this comment.
3rd party Github Actions should be pinned - high severity
A third-party GitHub Action was imported, and is not pinned via a hash. This leaves your CI/CD at risk for potential supply chain attacks, if the affected GitHub Action is compromised.
Suggested change
| - uses: pnpm/action-setup@v4 | |
| - uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4 |
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of LIB-2651 — design-system dependency-security cleanup. The published (production) surface is what reaches consuming apps; the dev/build tooling does not.
pnpm.overrides: patch the prod-reachable picomatch ReDoS (GHSA-c2c7-rcm5-vvqj) in both 2.x and 4.x ranges (via thetailwindcsspeer), staying within-major; plushandlebars≥4.7.9 andshell-quote≥1.8.4 (dev criticals).vitest4.1.1 → 4.1.6 (@vitest/browser advisory).pnpm audit --prod --audit-level highnow passes (0 high/critical; 2 moderate below the gate). Enforced via the husky pre-push hook and.github/workflows/audit.yml(the real required check — repo had no CI, local hook is skippable)..nvmrc20.11.0 → 22.12.0 (align withengines.node);renovate.json.Before un-drafting
SKIP_*) — runpnpm build+ the storybook suite to validate before marking ready.Deferred to backlog (dev-only): the EOL Storybook
babel-traversechain and modernizingcard-list's toolchain.