feat(FzCardList): re-export FzActionProps and FzBadgeTone from the package entry#383
Draft
sergioterrasifiscozen wants to merge 1 commit into
Draft
feat(FzCardList): re-export FzActionProps and FzBadgeTone from the package entry#383sergioterrasifiscozen wants to merge 1 commit into
sergioterrasifiscozen wants to merge 1 commit into
Conversation
…ackage entry Both types are part of the public surface of FzCardList: - FzActionProps is consumed by FzCardListItemProps.actions and emitted in the fzaction:click signature. - FzBadgeTone is consumed by FzCardListItemProps.badge. Re-exporting them from @fiscozen/card-list lets consumers obtain the typings from the same entry as the components, without depending on @fiscozen/action or @fiscozen/badge directly. Add a small spec that locks the contract: importing the re-exported types from the package barrel must keep compiling under vue-tsc. No behavior change.
sergioterrasifiscozen
requested review from
francesca-vago
and removed request for
francesca-vago
sergioterrasifiscozen
changed the title
francesca-vago
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosa
@fiscozen/card-listora re-esportaFzActionProps(originale@fiscozen/action) eFzBadgeTone(originale@fiscozen/badge) dal suo entry point. Entrambi i tipi sono parte della superficie pubblica diFzCardList:FzActionPropsfinisce inFzCardListItemProps.actionse nella firma difzaction:click.FzBadgeTonefinisce inFzCardListItemProps.badge.Prima:
Dopo:
Nessun cambio di behavior. I tipi originali rimangono dichiarati in
@fiscozen/action/@fiscozen/badge(questo è solo un re-export).Cosa fare in app dopo il rilascio di
@fiscozen/card-list@1.0.4@fiscozen/card-listda^1.0.3a^1.0.4infrontoffice/package.json(caret pin). Solo FO usa il pacchetto.<FzCardList>conactions, accorpare l'import in un'unica riga da@fiscozen/card-list:frontoffice/src/components/customers/Customers.vuefrontoffice/src/components/messages/Messages.vuefrontoffice/src/components/providers/Providers.vuefrontoffice/src/components/documents/Documents.vue