Skip to content

Add missing properties in typescript and propTypes definitions #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
canova merged 4 commits into from
Aug 4, 2025
Merged

Add missing properties in typescript and propTypes definitions #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67bc330
Add missing props to the MenuItemProps type definition
canova Aug 4, 2025
549e2ba
Add missing props to the ContextMenuTriggerProps type definition
canova Aug 4, 2025
fde4d2c
Add missing props to the SubMenuProps type definition
canova Aug 4, 2025
5c30c11
Add missing PropTypes to the SubMenu component
canova Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/SubMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ export default class SubMenu extends AbstractMenu {
onMouseOut: PropTypes.func,
forceOpen: PropTypes.bool,
forceClose: PropTypes.func,
parentKeyNavigationHandler: PropTypes.func
parentKeyNavigationHandler: PropTypes.func,
onClick: PropTypes.func,
data: PropTypes.object,
preventCloseOnClick: PropTypes.bool
};

static defaultProps = {
Expand All @@ -36,7 +39,10 @@ export default class SubMenu extends AbstractMenu {
onMouseOut: () => null,
forceOpen: false,
forceClose: () => null,
parentKeyNavigationHandler: () => null
parentKeyNavigationHandler: () => null,
onClick: () => null,
data: {},
preventCloseOnClick: false
};

constructor(props) {
Expand Down
14 changes: 14 additions & 0 deletions src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ declare module "@firefox-devtools/react-contextmenu" {
collect?: {(data: any): any},
disable?: boolean,
holdToDisplay?: number,
posX?: number,
posY?: number,
renderTag?: React.ElementType,
triggerOnLeftClick?: boolean,
disableIfShiftIsPressed?: boolean,
Expand All @@ -38,17 +40,29 @@ declare module "@firefox-devtools/react-contextmenu" {
divider?: boolean,
preventClose?: boolean,
onClick?: {(event: React.TouchEvent<HTMLDivElement> | React.MouseEvent<HTMLDivElement>, data: Object, target: HTMLElement): void} | Function,
onMouseLeave?: {(event: React.MouseEvent<HTMLDivElement>): void} | Function,
onMouseMove?: {(event: React.MouseEvent<HTMLDivElement>): void} | Function,
role?: string,
selected?: boolean,
children?: React.ReactNode,
}

export interface SubMenuProps {
title: React.ReactElement<any> | React.ReactText,
attributes?: React.HTMLAttributes<HTMLDivElement>,
className?: string,
disabled?: boolean,
hoverDelay?: number,
rtl?: boolean,
selected?: boolean,
onMouseMove?: {(event: React.MouseEvent<HTMLDivElement>): void} | Function,
onMouseOut?: {(event: React.MouseEvent<HTMLDivElement>): void} | Function,
forceOpen?: boolean,
forceClose?: {(): void} | Function,
parentKeyNavigationHandler?: {(event: React.KeyboardEvent): void} | Function,
preventCloseOnClick?: boolean,
onClick?: {(event: React.TouchEvent<HTMLDivElement> | React.MouseEvent<HTMLDivElement>, data: Object, target: HTMLElement): void} | Function,
data?: Object,
children?: React.ReactNode,
}

Expand Down