Make it possible to override the zeroAt value #5733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arai-a
force-pushed
the
start-relative
branch
from
3363bec to
9faf5e8
Compare
flodolo
reviewed
Dec 29, 2025
| MarkerContextMenu--end-selection-at-marker-end = | ||
| End selection at marker’s <strong>end</strong> | ||
| MarkerContextMenu--override-zero-at-marker-start = | ||
| Override zero at marker’s start |
Contributor
There was a problem hiding this comment.
I don't think this concept is going to be clear to localizers. Is "zero" just the start?
Contributor
Author
There was a problem hiding this comment.
Good point. It comes from "getZeroAt" name, but it's not obvious.
Other options I can think of are the following:
- Override the start of the timeline with marker's start
- Set the start of the timeline with marker's start
- Override the timeline origin with marker's start
- Set the timeline origin with marker's start
- Start the timeline from marker's start
And the following for the menu button:
- Starts at 100ms
- Starts from 100ms
- Origin at 100ms
- Origin overridden to 100ms
Can I have your opinion?
If there are better labels, let me know.
Contributor
There was a problem hiding this comment.
Let's wait for @canova and folks who understand the project — and target audience — better than me.
Personally, I would go with something like:
Align the timeline start with the marker start(orSet… to).- Starting point moved to 100ms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #5730
This adds "Override zero at marker’s start" menu item to markers, which overrides the "zeroAt" value.
When overridden the menu buttons at the top of the page gets "Zero at (timestamp)" button.
Clicking it resets the override.
Also this supports negative timestamp.
The timeline looks line the following when overridden.