Add Gateway API HTTPRoute support to the firefly-iii chart#117
Open
somaz94 wants to merge 1 commit into
Open
Conversation
Contributor
|
Got this working in my K8s cluster. Could you bump the firefly-iii-stack chart version as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in HTTPRoute template (Gateway API) to the
firefly-iiichart, mirroring the existing implementation in theimporterchart (#112). This lets users expose Firefly III through the Kubernetes Gateway API as an alternative to Ingress.Changes
templates/httproute.yaml, gated onhttpRoute.enabled(defaultfalse— no behavior change for existing users)httpRoutevalues block:enabled,annotations,hostnames,parentRefs(same shape as theimporterchart)firefly-iiichart1.9.17→1.10.0and the matchingfirefly-iii-stackdependency pinhelm-docsValidation
helm templatewithhttpRoute.enabled=falserenders no HTTPRoute; withenabled=trueplus customhostnames/parentRefs/annotationsrenders a valid HTTPRoute pointing at the servicehelm lintpassesct lint --config ct.yaml --charts charts/firefly-iiiand--charts charts/firefly-iii-stackboth passrelated: firefly-iii/firefly-iii#12208