Skip to content

cost, vm serialization: add fixtures#544

Merged
mjain-jump merged 1 commit into
agave-v4.1.0-beta.3from
mjain/add-cost-and-vm-serialization-fixtures
Jun 10, 2026
Merged

cost, vm serialization: add fixtures#544
mjain-jump merged 1 commit into
agave-v4.1.0-beta.3from
mjain/add-cost-and-vm-serialization-fixtures

Conversation

@mjain-jump

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings June 10, 2026 20:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for running test-vector fixtures for transaction cost modeling and VM serialization by introducing a new cost fixture executor binary and wiring both fixture sets into the existing run_test_vectors.sh harness.

Changes:

  • Add test_exec_cost Rust binary to execute CostFixture vectors and compare results against expected outputs.
  • Extend scripts/run_test_vectors.sh to run cost/fixtures and vm_serialization/fixtures as part of the job matrix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/bin/test_exec_cost.rs New CLI binary to decode CostFixture inputs and compare execute_cost results to expected outputs.
scripts/run_test_vectors.sh Registers test_exec_cost and test_exec_vm_serialization fixture directories in the test-vector runner job list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/bin/test_exec_cost.rs
Comment on lines +13 to +14
let blob = std::fs::read(input).unwrap();
let fixture = CostFixture::decode(&blob[..]).unwrap();
Comment thread src/bin/test_exec_cost.rs
Comment on lines +15 to +23
let Some(context) = fixture.input else {
println!("No context found.");
return false;
};

let Some(expected) = fixture.output else {
println!("No fixture found.");
return false;
};
@mjain-jump mjain-jump force-pushed the mjain/add-cost-and-vm-serialization-fixtures branch from 2026b40 to 7d3cb11 Compare June 10, 2026 20:33
@mjain-jump mjain-jump enabled auto-merge (squash) June 10, 2026 20:59
@mjain-jump mjain-jump merged commit 4676190 into agave-v4.1.0-beta.3 Jun 10, 2026
4 checks passed
@mjain-jump mjain-jump deleted the mjain/add-cost-and-vm-serialization-fixtures branch June 10, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants