fix: income by pct txns value#352
Merged
Merged
Conversation
amliu-jumptrading
requested review from
asuzuki-jumptrading and
atsai-jumptrading
There was a problem hiding this comment.
Pull request overview
Fixes the “Income Distribution by Percent Txns” tooltip showing incorrect income values by ensuring the chart data uses lamport totals (per percentile band) rather than normalized percentage shares.
Changes:
- Update
percentileSpreadto return absolute income per percentile band (bandSum) instead of share-of-total. - Remove now-unneeded
totalnormalization insidepercentileSpread, relying on the bar component to compute percentages for display.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
atsai-jumptrading
approved these changes
Jun 9, 2026
asuzuki-jumptrading
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Income Distribution by Percent Txns bar tooltips were showing incorrect income values because they were using percentage values instead of lamport values.