Open
Conversation
1e25b23 to
6a5a968
Compare
6a5a968 to
ae89a5e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The upload of two allure reports from the Core Integration Tests is broken and one of the reports leads to a dead link.
I implemented a new version of
firebolt-db/action-allure-report@v2which supports the upload of multiple reports in one job. For consistency, I also use the new action for the single report upload from the v2 integration tests.I changed URLs to the reports, but they are only linked from GHA.
Note: The deployment of the reports happens through a GHA provided GHA workflow to the gh-pages branch that runs separately. The reports will be available once that flow finishes. This logic is unchanged and is the default "GHA-way" to deploy gh-pages.