fix(firestore): use Firestore instead of FirebaseFirestore in error messages

[atharv290]

This PR updates Firestore lite API error messages to use the v9 modular API
type name Firestore instead of the legacy v8 name FirebaseFirestore.

No behavior changes; string-only fix for consistency and clarity.

Fixes #9434

[changeset-bot]

⚠️ No Changeset found

Latest commit: b562de1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @atharv290, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the clarity and consistency of error messages within the Firestore Lite API. It updates specific error strings to reflect the current v9 modular API terminology, replacing an older type name with its contemporary equivalent. The primary goal is to improve the developer experience by ensuring error messages are aligned with the latest API standards, without introducing any functional changes to the system.

Highlights

• Error Message Consistency: Updated Firestore Lite API error messages to use the modern v9 modular API type name 'Firestore' instead of the legacy 'FirebaseFirestore'.
• No Behavior Change: This change is purely a string-only fix for consistency and clarity, with no impact on the application's behavior or functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates error messages in the Firestore lite API to use Firestore instead of the legacy FirebaseFirestore name, which improves consistency with the v9 modular API. The changes in packages/firestore/src/lite-api/reference.ts are correct. However, it appears that related test cases were not updated, which will likely cause the test suite to fail. I've left specific comments with details.

[gemini-code-assist]

This error message change is correct. However, it looks like the corresponding unit test in packages/firestore/test/lite/integration.test.ts (around line 292) that validates this error message has not been updated. This will cause the test to fail. Please update the test to expect 'Firestore' instead of 'FirebaseFirestore'.

[gemini-code-assist]

While updating this error message, it would be a good opportunity to add a test case to packages/firestore/test/lite/integration.test.ts that validates this specific error for the collection() function. This would improve test coverage and ensure this error message is validated, similar to the existing test for doc().

[atharv290]

Thanks for the suggestion! I’ve updated the existing doc() test to expect
Firestore and added a corresponding test for collection() to improve
coverage. Please let me know if this looks good.