Extension to migrate data from functions.config() to params#67
Extension to migrate data from functions.config() to params#67inlined wants to merge 1 commit intofunctions-migrationsfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new skill for migrating Firebase Functions configuration data from the deprecated functions.config() to modern params and environment files. It also updates the firebase-functions-params-refactor skill to correctly reference this new migration tool. Feedback was provided to correct the handling of local environment files, noting that .env.local should contain both secret and non-secret local values and must be added to .gitignore to prevent accidental commits.
| 2. **Non-secret values** should be placed in `.env.local`. These can be checked into source control. | ||
| 3. Any **sensitive/secret values** should be placed in `.secrets.local`. | ||
| 4. **IMPORTANT**: Ensure that `.secrets.local` is added to `.gitignore`. |
There was a problem hiding this comment.
The .env.local file is intended for local environment overrides and should not be committed to version control. Additionally, Firebase does not natively recognize a .secrets.local file; local secrets for the emulator should also be placed in .env.local, which must be ignored via .gitignore.
| 2. **Non-secret values** should be placed in `.env.local`. These can be checked into source control. | |
| 3. Any **sensitive/secret values** should be placed in `.secrets.local`. | |
| 4. **IMPORTANT**: Ensure that `.secrets.local` is added to `.gitignore`. | |
| 2. Local values (both secret and non-secret) should be placed in .env.local. | |
| 3. IMPORTANT: Ensure that .env.local is added to .gitignore. |
Need to play with it, but creating a PR for human (and robo) review