Skip to content

Extension to migrate data from functions.config() to params#67

Draft
inlined wants to merge 1 commit intofunctions-migrationsfrom
inlined.params-data-migration
Draft

Extension to migrate data from functions.config() to params#67
inlined wants to merge 1 commit intofunctions-migrationsfrom
inlined.params-data-migration

Conversation

@inlined
Copy link
Copy Markdown
Member

@inlined inlined commented Apr 4, 2026

Need to play with it, but creating a PR for human (and robo) review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new skill for migrating Firebase Functions configuration data from the deprecated functions.config() to modern params and environment files. It also updates the firebase-functions-params-refactor skill to correctly reference this new migration tool. Feedback was provided to correct the handling of local environment files, noting that .env.local should contain both secret and non-secret local values and must be added to .gitignore to prevent accidental commits.

Comment on lines +60 to +62
2. **Non-secret values** should be placed in `.env.local`. These can be checked into source control.
3. Any **sensitive/secret values** should be placed in `.secrets.local`.
4. **IMPORTANT**: Ensure that `.secrets.local` is added to `.gitignore`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The .env.local file is intended for local environment overrides and should not be committed to version control. Additionally, Firebase does not natively recognize a .secrets.local file; local secrets for the emulator should also be placed in .env.local, which must be ignored via .gitignore.

Suggested change
2. **Non-secret values** should be placed in `.env.local`. These can be checked into source control.
3. Any **sensitive/secret values** should be placed in `.secrets.local`.
4. **IMPORTANT**: Ensure that `.secrets.local` is added to `.gitignore`.
2. Local values (both secret and non-secret) should be placed in .env.local.
3. IMPORTANT: Ensure that .env.local is added to .gitignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants