Agent Skills for CF3 V1-V2 Migration#60
Draft
shettyvarun268 wants to merge 3 commits intofirebase:mainfrom
Draft
Agent Skills for CF3 V1-V2 Migration#60shettyvarun268 wants to merge 3 commits intofirebase:mainfrom
shettyvarun268 wants to merge 3 commits intofirebase:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new skill for migrating Firebase Functions from V1 to V2 using a destructuring compatibility shim, including architectural documentation and a function mapping reference. Feedback suggests clarifying that the context shim is unavailable for https.onCall functions and noting that test mock keys must match the specific trigger type, such as 'data' for Firestore or 'message' for PubSub, to ensure correct test updates.
skills/firebase-v1-v2-migration/references/signature-mapping.md
Outdated
Show resolved
Hide resolved
inlined
reviewed
Apr 1, 2026
Member
inlined
left a comment
There was a problem hiding this comment.
Looks mostly good:
- We should possibly get my params rewrite code into main instead of a staging branch so you can reference it
- We should add instructions on how to convert runWith into either a global setGlobalOptions or per-function options objects
- We can maybe explain the value of concurrency and ask if they want to pay for more CPU if they want concurrency or set CPU to "gcfv1" to restore the old CPU?
- As a smoke/integration test can you run this against our samples repo and post a git commit to the description for code reviewing the output?
Author
|
Addressing the Comments by inlined:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new skill for AI agents to safely migrate Firebase Functions from V1 to V2 using the v1-v2 compat layer(destructuring). It provides step-by-step guidance for migrating function signatures without rewriting internal business logic, and includes checks for configurations(if functions.config() has been migrated from) and unit test signature mismatches.
It also adds reference documentation containing a comprehensive V1-to-V2 function parity table and an deep dive into the compat layer itself. This is to ensure that the agent has enough context and reference to understand how the signature has changed from v1 to v2 and also understand what the compat layer intends to do.