Edit Session - Allow add, delete rows#2196
Draft
anandBalachandar wants to merge 3 commits into
Draft
Conversation
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
heswell
reviewed
Jul 3, 2026
| #inEditMode = false; | ||
|
|
||
| constructor(dataSource: EditApi) { | ||
| #handleRowSelection = (count: number) => { |
Contributor
There was a problem hiding this comment.
this doesn't belong on here, its duplicating exactly what the datasSource already does.
heswell
reviewed
Jul 3, 2026
| } | ||
| } | ||
|
|
||
| get selectionCount() { |
Contributor
There was a problem hiding this comment.
why do we need to replicate dataSource selectionCount on the editSession ?
heswell
reviewed
Jul 3, 2026
| } | ||
| } | ||
|
|
||
| restoreRows(keys: string[]) { |
heswell
reviewed
Jul 3, 2026
heswell
reviewed
Jul 3, 2026
|
|
||
| useMemo(() => { | ||
| editSession?.on("editState", setEditState); | ||
| editSession?.on("selectionCount", setSelectionCount); |
Contributor
There was a problem hiding this comment.
editSession.dataSource.on(""row-selection", setSelectionCount)
heswell
reviewed
Jul 3, 2026
| }; | ||
|
|
||
| deleteRow: DataSourceDeleteHandler = async (key) => { | ||
| deleteRow: DataSourceDeleteHandler = async (key, mode: DeleteRowMode = "hard") => { |
Contributor
There was a problem hiding this comment.
this implementation needs to go in TickingArrayDataSource, where it should do an rpc request, see the implementation of editCell
anandBalachandar
force-pushed
the
feature/edit-session-allow-row-deletions
branch
from
ec16206 to
fba1b52
Compare
anandBalachandar
force-pushed
the
feature/edit-session-allow-row-deletions
branch
from
754fdd8 to
d9add1f
Compare
anandBalachandar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to editing cells, enabling deletions within EditSession - NOT COMPLETE