feat: add vuu_msg default column to session tables (#2166)#2167
Open
VivekJariwala50 wants to merge 1 commit into
Open
feat: add vuu_msg default column to session tables (#2166)#2167VivekJariwala50 wants to merge 1 commit into
VivekJariwala50 wants to merge 1 commit into
Conversation
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
|
|
Author
Add a default column vuu_msg to SessionTableDef so that error messages can be stored per-row in the session table and displayed on the UI. This supports the table edit mode feature. Changes: - DefaultColumn.scala: Added VuuMsg case to enum and updated getDefaultColumns() to only include it for session tables - TableDef.scala: Passes isSessionTable flag when initialising default columns so vuu_msg is only injected in SessionTableDef - TableAsserts.scala: Updated to dynamically filter all registered default column names instead of hardcoding specific ones, ensuring tests remain forward-compatible with future default column additions - DefaultColumnTest.scala: Added test scenarios to verify vuu_msg is present in SessionTableDef and absent in regular TableDef - ModuleSyntaxTest.scala: Updated column-count assertion to use the non-session default column list - TableWSApiTest.scala: Updated column-list assertion to use the non-session default column list
VivekJariwala50
force-pushed
the
feature/vuu-msg-default-column
branch
from
ca41c51 to
7d1f7f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a default column vuu_msg to SessionTableDef so that error messages can be stored per-row in the session table and displayed on the UI. This supports the table edit mode feature.
Changes: