Open
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
==========================================
+ Coverage 81.34% 81.74% +0.39%
==========================================
Files 65 65
Lines 4648 4673 +25
Branches 792 800 +8
==========================================
+ Hits 3781 3820 +39
+ Misses 852 837 -15
- Partials 15 16 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #605.
Summary
Right now, reviewers can reject a push without leaving any context, and push authors can’t tell who rejected it or why. This PR makes rejections explicit by requiring a reason and recording the rejecting reviewer, then surfaces that information in the UI.
UI
Attestationmodal) that requires a reviewer to enter a reason before a rejection can be submitted.PushDetailsby extracting components to reduce complexity and improve readability/maintainability.Backend
Rejectiontype containingreviewer,reason, andtimestamp.