Conversation
Configure vite-plugin-pwa with generateSW strategy and autoUpdate behavior so the app at convert.fidnii.io can be installed and works offline. Precaches the app shell (~5 MB) and uses runtime caching for WASM pipeline files (StaleWhileRevalidate) and the Web Awesome CDN stylesheet (CacheFirst). Moves favicon assets into public/ and replaces the broken site.webmanifest with an auto-generated manifest.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
fidnii-convert | 10ccc3d | Commit Preview URL Branch Preview URL |
Feb 19 2026, 02:29 AM |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Progressive Web App (PWA) support to the convert example application, enabling offline functionality and installability. The changes configure vite-plugin-pwa to generate a service worker that precaches the app shell and implements runtime caching strategies for WebAssembly pipeline files and external CDN resources.
Changes:
- Configures vite-plugin-pwa with app manifest, precaching, and runtime caching strategies
- Registers service worker with autoUpdate mode for seamless updates
- Moves favicon assets to public/ directory and removes broken site.webmanifest in favor of auto-generated manifest
- Adds proper meta tags for PWA support (description, theme-color) and CORS attribute for CDN stylesheet
Reviewed changes
Copilot reviewed 6 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Adds VitePWA plugin with manifest config, workbox precaching patterns, and runtime caching for WASM/CDN |
| package.json | Adds vite-plugin-pwa and workbox-window dependencies |
| main.ts | Registers service worker with immediate activation using virtual:pwa-register |
| vite-env.d.ts | Adds type reference for vite-plugin-pwa/client |
| index.html | Adds PWA meta tags (description, theme-color) and crossorigin attribute for CDN stylesheet |
| converter.ts | Removes unnecessary @ts-expect-error comment for import.meta.env |
| public/favicon/* | Adds/moves favicon assets (ico, png files) to public directory |
| favicon/site.webmanifest | Removes broken static manifest (replaced by auto-generated one) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add a CacheFirst runtime caching rule for mri.nii.gz so the sample data is available offline after first download.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configure vite-plugin-pwa with generateSW strategy and autoUpdate
behavior so the app at convert.fidnii.io can be installed and works
offline. Precaches the app shell (~5 MB) and uses runtime caching for
WASM pipeline files (StaleWhileRevalidate) and the Web Awesome CDN
stylesheet (CacheFirst). Moves favicon assets into public/ and replaces
the broken site.webmanifest with an auto-generated manifest.