Skip to content

Conversation

@esmith1729
Copy link
Collaborator

@esmith1729 esmith1729 commented Jan 28, 2026

Closes #587

Description

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.29%. Comparing base (d15484e) to head (5092263).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
+ Coverage   96.28%   96.29%   +0.01%     
==========================================
  Files          48       48              
  Lines        1882     1890       +8     
==========================================
+ Hits         1812     1820       +8     
  Misses         70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the VESUVIO script transform to support multiple run numbers by turning list inputs into the correct Mantid-style runno string, and it adds tests to cover the new behaviors.

Changes:

  • Extend VesuvioTransform.apply to accept job.inputs["runno"] as either a scalar or a list and convert lists into either a contiguous range string ("start-end") or a comma-separated list string ("a,b,c").
  • Preserve existing behavior for single run numbers (string or scalar) by normalizing everything through a computed runno_str.
  • Add three new tests in test_vesuvio_transforms.py to validate contiguous multi-run lists, non-contiguous multi-run lists, and single-element lists.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
fia_api/scripts/transforms/vesuvio_transform.py Implements runno normalization logic to handle lists of run numbers, emitting either range or comma-separated strings and wiring this into the existing transform loop.
test/scripts/transforms/test_vesuvio_transforms.py Adds unit tests verifying that VESUVIO transforms produce the correct runno line for contiguous lists, non-contiguous lists, and single-element lists, plus existing single-run behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VESUVIO: Handle rule summation for the transformation

2 participants