-
Notifications
You must be signed in to change notification settings - Fork 1
Changing FIA-API vesuvio script to allow summing multiple runs #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
==========================================
+ Coverage 96.28% 96.29% +0.01%
==========================================
Files 48 48
Lines 1882 1890 +8
==========================================
+ Hits 1812 1820 +8
Misses 70 70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…s/FIA-API into vesuvio_sum_multiple_runs
…s/FIA-API into vesuvio_sum_multiple_runs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the VESUVIO script transform to support multiple run numbers by turning list inputs into the correct Mantid-style runno string, and it adds tests to cover the new behaviors.
Changes:
- Extend
VesuvioTransform.applyto acceptjob.inputs["runno"]as either a scalar or a list and convert lists into either a contiguous range string ("start-end") or a comma-separated list string ("a,b,c"). - Preserve existing behavior for single run numbers (string or scalar) by normalizing everything through a computed
runno_str. - Add three new tests in
test_vesuvio_transforms.pyto validate contiguous multi-run lists, non-contiguous multi-run lists, and single-element lists.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| fia_api/scripts/transforms/vesuvio_transform.py | Implements runno normalization logic to handle lists of run numbers, emitting either range or comma-separated strings and wiring this into the existing transform loop. |
| test/scripts/transforms/test_vesuvio_transforms.py | Adds unit tests verifying that VESUVIO transforms produce the correct runno line for contiguous lists, non-contiguous lists, and single-element lists, plus existing single-run behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closes #587
Description