Skip to content

Add tests for non-local next from inside nested subs #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fglock merged 2 commits into from
Jan 21, 2026
Merged

Add tests for non-local next from inside nested subs #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f832a4
Add tests for non-local next from inside nested subs
fglock Jan 21, 2026
36a8955
Ignore local .err/.out and .windsurf artifacts
fglock Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,6 @@ test_yaml_0yml
# Ignore some Perl modules we are testing
Image-ExifTool-*

/.err
/.out
/.windsurf/
107 changes: 107 additions & 0 deletions src/test/resources/unit/control_flow.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,113 @@ subtest 'local next - labeled' => sub {
'labeled next continues correct loop');
};

subtest 'non-local next - unlabeled (inside sub)' => sub {
my @output;
my $do_next = sub {
my ($i, $j) = @_;
push @output, "in-sub-$i,$j";
next;
push @output, "after-next-$i,$j";
};

for my $i (1..2) {
for my $j (1..3) {
push @output, "before-$i,$j";
if ($j == 2) {
$do_next->($i, $j);
}
push @output, "after-$i,$j";
}
}

is_deeply(
\@output,
[
'before-1,1', 'after-1,1',
'before-1,2', 'in-sub-1,2',
'before-1,3', 'after-1,3',
'before-2,1', 'after-2,1',
'before-2,2', 'in-sub-2,2',
'before-2,3', 'after-2,3',
],
'next from inside sub continues the innermost loop',
);
};

subtest 'non-local next - labeled (inside sub)' => sub {
my @output;
my $do_next_outer = sub {
my ($i, $j) = @_;
push @output, "in-sub-$i,$j";
next OUTER;
push @output, "after-next-$i,$j";
};

OUTER: for my $i (1..3) {
for my $j (1..3) {
push @output, "before-$i,$j";
if ($j == 2) {
$do_next_outer->($i, $j);
}
push @output, "after-$i,$j";
}
}

is_deeply(
\@output,
[
'before-1,1', 'after-1,1',
'before-1,2', 'in-sub-1,2',
'before-2,1', 'after-2,1',
'before-2,2', 'in-sub-2,2',
'before-3,1', 'after-3,1',
'before-3,2', 'in-sub-3,2',
],
'labeled next from inside sub continues the correct labeled loop',
);
};

subtest 'non-local next - labeled (A->B->C calls)' => sub {
my @output;
my $C = sub {
my ($i, $j) = @_;
push @output, "in-C-$i,$j";
next OUTER;
push @output, "after-next-$i,$j";
};
my $B = sub {
my ($i, $j) = @_;
$C->($i, $j);
};
my $A = sub {
my ($i, $j) = @_;
$B->($i, $j);
};

OUTER: for my $i (1..3) {
for my $j (1..3) {
push @output, "before-$i,$j";
if ($j == 2) {
$A->($i, $j);
}
push @output, "after-$i,$j";
}
}

is_deeply(
\@output,
[
'before-1,1', 'after-1,1',
'before-1,2', 'in-C-1,2',
'before-2,1', 'after-2,1',
'before-2,2', 'in-C-2,2',
'before-3,1', 'after-3,1',
'before-3,2', 'in-C-3,2',
],
'labeled next propagates through A->B->C and continues the correct labeled loop',
);
};

subtest 'local redo - unlabeled' => sub {
my @output;
my $count = 0;
Expand Down