Fix pack/unpack regressions and string interpolation #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix string interpolation: @!, @+, @- arrays do not interpolate in double-quoted strings
- Fix pack('c') to use numeric overload (0+) instead of string overload ("")
- Fix pack/unpack @! to use byte-based positioning for UTF-8 strings
- Improve pack template parsing for modifiers with counts (e.g., @!2, c!4)
- Remove duplicate JAR_PATH check in jperl launcher script
These changes fix regressions in op/pack.t and ensure correct behavior
for pack format modifiers, numeric overloading, and UTF-8 byte alignment.
- Add XS::APItest Java module providing modify_pv for pack pointer tests - Add XS::APItest Perl module loader - Add skip_control_flow.t test validating last SKIP behavior across call frames
- Add pushGroupStart/popGroupStart/getGroupStart for group tracking - Add byteOffsetOfIndex/moveToBytePosition/moveToIndex for positioning - Add byteSize for byte-based size calculation - Add modifyPointer to PointerPackHandler for XS::APItest support These methods are required by the pack/unpack @! byte-alignment fixes.
This test is for control flow features, not pack/unpack fixes. Test #2 is failing in current master, so removing from this PR.
This reverts commit 112560d.
… of this PR The test fails because last SKIP doesn't propagate through scalar context function calls. This is a known limitation in master that requires complex bytecode changes that cause ASM verification errors. Removing from this PR as it's not related to pack/unpack or string interpolation fixes.
…nd scope of this PR" This reverts commit a58d96c.
The test documents a known limitation in master where last SKIP doesn't propagate through scalar context function calls. Fixing this requires complex bytecode changes that cause ASM verification errors. This is not related to the pack/unpack and string interpolation fixes in this PR, so removing it to keep the PR focused.
Owner
Author
|
Closing to focus on control flow fix separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes pack/unpack regressions and string interpolation bugs.
Changes
Testing