Fg/deser pr4

[fgladwin]

No description provided.

[Copilot]

Pull request overview

This PR adds deserialization functionality to rocAL by implementing the rocalDeserialize API function. This allows reconstructing a rocAL pipeline from a serialized protobuf representation, complementing the existing serialization capability.

Key changes:

• Added rocalDeserialize function to parse serialized pipeline data and recreate a RocalContext
• Introduced RocalPipelineParams struct to allow optional overrides of pipeline parameters during deserialization
• Added necessary protobuf header includes for deserialization support

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
rocAL/source/api/rocal_api.cpp	Implements the rocalDeserialize function with protobuf parsing and context creation logic
rocAL/include/api/rocal_api_types.h	Defines the RocalPipelineParams struct with optional pipeline configuration parameters
rocAL/include/api/rocal_api.h	Declares the public API for rocalDeserialize function

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The return value of ParseFromCodedStream is not checked. If parsing fails, the function will continue execution with an incompletely initialized pipe object, potentially causing undefined behavior. Add error handling: if (!pipe.ParseFromCodedStream(&coded_input)) { THROW(\"Failed to parse serialized pipeline\"); }

Suggested change

	google::protobuf::io::CodedInputStream coded_input(
	if (!pipe.ParseFromCodedStream(&coded_input)) {
	THROW("Failed to parse serialized pipeline");
	}

[Copilot]

The inline comment indicates incomplete functionality ('Need to set dtype in protobuf/just use default value'). This TODO-style comment should either be addressed before merging or converted to a proper TODO/FIXME comment for tracking: // TODO: Support configurable dtype from protobuf instead of hardcoding FP32

Suggested change

	std::max(device_id, 0),
	RocalTensorDataType::FP32); // TODO: Support configurable dtype from protobuf instead of hardcoding FP32

[Copilot]

The return value or potential exceptions from deserialize are not handled. If deserialization of the master graph fails, the partially constructed context will be returned without cleanup, causing a resource leak. Wrap this call in proper error handling and ensure context cleanup on failure.

Suggested change

	num_threads,
	prefetch_queue_depth,
	RocalTensorDataType::FP32); // Need to set dtype in protobuf/just use default value
	bool deserialized = static_cast<Context*>(context)->master_graph->deserialize(&pipe);
	if (!deserialized) {
	delete static_cast<Context*>(context);
	context = nullptr;
	}
	} catch (const std::exception& e) {
	if (context) {
	delete static_cast<Context*>(context);
	context = nullptr;
	}

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Inconsistent indentation: this line uses 3 spaces while surrounding lines use 4 spaces for indentation.

Suggested change

	pipe_params.prefetch_queue_depth = pipe.prefetch_queue_depth();
	pipe_params.prefetch_queue_depth = pipe.prefetch_queue_depth();