feat: minimum-commission-rate#138
Draft
Jonathansumner wants to merge 23 commits intominimum-commission-rate-featurefrom
Draft
feat: minimum-commission-rate#138Jonathansumner wants to merge 23 commits intominimum-commission-rate-featurefrom
Jonathansumner wants to merge 23 commits intominimum-commission-rate-featurefrom
Conversation
Jonathansumner
changed the title
Jonathansumner
changed the title
Jonathansumner
force-pushed
the
feat/minimum-commission-rate
branch
from
9372d62 to
db28752
Compare
github-actions
bot
added
C:x/distribution
C:x/gov
C:x/params
C:Simulations
C:x/slashing
C:x/staking
C:CLI
labels
Jonathansumner
commented
Jun 7, 2023
Member
Author
There was a problem hiding this comment.
This needs a 2nd pair of eyes, I'd say
Jonathansumner
commented
Jun 8, 2023
| return | ||
| } | ||
|
|
||
| func (k Keeper) MinCommissionRate(ctx sdk.Context) (res *sdk.Dec) { |
Member
Author
There was a problem hiding this comment.
min commission not present - test behaviour when not present, when params don't contain that value
Jonathansumner
commented
Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.