-
Notifications
You must be signed in to change notification settings - Fork 0
Move token generation before checkout #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Any good way to test this, or just YOLO? 🚀 |
@jacob-curley-fnal any ideas? |
|
I changed the referenced commit hash for the workflow in alarms app: https://github.com/fermi-ad/flutter-alarms-app/pull/2/commits/bc988ee61444943d1e3e3bab50eb64c885bb387b |
|
Now it can't even checkout the main repo |
| if: ${{ inputs.test != '' }} | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line is the source of all the trouble. You could revert all the other changes and just remove this line, and I think it would work,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or at least, remove the whole permissions piece
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's only under the Integration-tests: job, but the Linter-UnitTest-SmokeTest-Build: job is what's running and failing in my alarms-app PR. It doesn't have the extra permissions block
No description provided.