Add EasyGift to detector#49
Open
nathanh59 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Why are you doing this? What problem is it solving? Why is is good for our merchants? etc. If you're doing something from Ora PM then you can just copy the "why?" part here.
What?
What does this PR actually add. What code did you change? Did you introduce any new patterns? Etc.
Demo / Screenshots
Using recordit.co and/or monosnap to give screenshots and gif demos of your code. You can embed them in here like this:
How was it tested?
What tests did you run? What scenarios did you test. What tests do you still need to run?
How can you test it.
How can the reviewer test this PR? Are there any special steps required? For example:
bundle install(if you added bower assets)bower install(if you added gems)/some_pagein your browser and do X, Y and Z (if there is a visual components)rails consoleand typesome code(if there are code components to test)