Open
Conversation
vicbl
force-pushed
the
issue-68-fizzbuzz
branch
from
1ffa9e1 to
0a8f181
Compare
fengyuanyang
requested changes
Oct 25, 2020
Owner
fengyuanyang
left a comment
fengyuanyang
left a comment
There was a problem hiding this comment.
pleases remove , printFizzBuzz
it seems useless here
|
|
||
| public void printFizzBuzz(int numberIteration) { | ||
| for (int i = 1; i <= numberIteration; i++) { | ||
| System.out.println(fizzBuzz(i)); |
Owner
There was a problem hiding this comment.
print method is useless in unit tests.
| FizzBuzz fizzBuzz = new FizzBuzz(); | ||
|
|
||
| @Test | ||
| public void printFizzBuzz_given15Iterations_fizzBuzzIsCorrectlyPrinted() { |
Owner
There was a problem hiding this comment.
you can hard cord fizzbuzz from 1 to 15 and check the result with FizzBuzz, print is not going to make any sense here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.