Putting the C++ files in a src directory#16
Merged
edgar-bonet merged 1 commit intomasterfrom May 5, 2026
Merged
Conversation
Contributor
|
Thanks! This is a good start! I request some changes though. Please, amend this pull request by:
As for the commit message, please try to follow the recommendations in the article How to Write a Git Commit Message. |
arowana755
force-pushed
the
commit_timothee
branch
2 times, most recently
from
4321386 to
fd7b110
Compare
arowana755
force-pushed
the
commit_timothee
branch
5 times, most recently
from
54e21de to
fffca48
Compare
Author
|
It is done now. |
Contributor
|
All the tests pass now. Good job! Now, some final teweaks before I merge. Could you please do the following?
|
edgar-bonet
reviewed
May 4, 2026
arowana755
force-pushed
the
commit_timothee
branch
2 times, most recently
from
e5d6c14 to
7b0285b
Compare
Author
|
Now it should be good |
edgar-bonet
force-pushed
the
commit_timothee
branch
from
7b0285b to
274c4e0
Compare
Contributor
|
Merged (with one amendment), thanks! The only thing I changed: in the compile options, you had replaced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.