Skip to content

Updating for dropwizard 1.0.0 and dropwizard-junit 0.7 version bump#91

Open
willh wants to merge 1 commit into
federecio:masterfrom
willh:master
Open

Updating for dropwizard 1.0.0 and dropwizard-junit 0.7 version bump#91
willh wants to merge 1 commit into
federecio:masterfrom
willh:master

Conversation

@willh

@willh willh commented Jul 27, 2016

Copy link
Copy Markdown

Summary of changes

  1. Version bumps for Dropwizard 1.0.0:
  2. Minor code changes to handle changed Dropwizard APIs
    • getViewConfiguration in SwaggerBundle.java changed from returning ImmutableMap to vanilla Map
    • getJerseyRootPath in ConfigurationHelper.java changed to handle Optional<String> returned from config properties
  3. Maven Enforcer plugin DependencyConvergence check removed due to unresolved upstream conflicts (full detail on conflicting dependencies listed below)

Conflicting dependencies in DependencyConvergence check:

[WARNING]
Dependency convergence error for org.apache.commons:commons-lang3:3.4 paths to dependency are:
+-io.federecio:dropwizard-swagger:0.8.0-SNAPSHOT
+-io.dropwizard:dropwizard-core:1.0.0
+-io.dropwizard:dropwizard-configuration:1.0.0
+-org.apache.commons:commons-lang3:3.4
and
+-io.federecio:dropwizard-swagger:0.8.0-SNAPSHOT
+-io.dropwizard:dropwizard-core:1.0.0
+-io.dropwizard:dropwizard-jersey:1.0.0
+-org.apache.commons:commons-lang3:3.4
and
+-io.federecio:dropwizard-swagger:0.8.0-SNAPSHOT
+-org.seleniumhq.selenium:selenium-java:2.45.0
+-org.seleniumhq.selenium:selenium-htmlunit-driver:2.45.0
+-net.sourceforge.htmlunit:htmlunit:2.15
+-org.apache.commons:commons-lang3:3.3.2

[WARNING]
Dependency convergence error for org.slf4j:slf4j-api:1.7.21 paths to dependency are:
+-io.federecio:dropwizard-swagger:0.8.0-SNAPSHOT
+-io.dropwizard:dropwizard-core:1.0.0
+-io.dropwizard:dropwizard-jackson:1.0.0
+-org.slf4j:slf4j-api:1.7.21
and
+-io.federecio:dropwizard-swagger:0.8.0-SNAPSHOT
+-io.dropwizard:dropwizard-core:1.0.0
+-io.dropwizard:dropwizard-logging:1.0.0
+-org.slf4j:slf4j-api:1.7.21
and
+-io.federecio:dropwizard-swagger:0.8.0-SNAPSHOT
+-io.dropwizard:dropwizard-core:1.0.0
+-io.dropwizard:dropwizard-logging:1.0.0
+-org.slf4j:jul-to-slf4j:1.7.21
+-org.slf4j:slf4j-api:1.7.21
and
+-io.federecio:dropwizard-swagger:0.8.0-SNAPSHOT
+-io.dropwizard:dropwizard-core:1.0.0
+-io.dropwizard:dropwizard-logging:1.0.0
+-org.slf4j:log4j-over-slf4j:1.7.21
+-org.slf4j:slf4j-api:1.7.21
and
+-io.federecio:dropwizard-swagger:0.8.0-SNAPSHOT
+-io.dropwizard:dropwizard-core:1.0.0
+-io.dropwizard:dropwizard-logging:1.0.0
+-org.slf4j:jcl-over-slf4j:1.7.21
+-org.slf4j:slf4j-api:1.7.21
and
+-io.federecio:dropwizard-swagger:0.8.0-SNAPSHOT
+-io.dropwizard:dropwizard-core:1.0.0
+-io.dropwizard:dropwizard-metrics:1.0.0
+-org.slf4j:slf4j-api:1.7.21
and
+-io.federecio:dropwizard-swagger:0.8.0-SNAPSHOT
+-io.dropwizard:dropwizard-core:1.0.0
+-io.dropwizard:dropwizard-servlets:1.0.0
+-org.slf4j:slf4j-api:1.7.21
and
+-io.federecio:dropwizard-swagger:0.8.0-SNAPSHOT
+-io.dropwizard:dropwizard-core:1.0.0
+-io.dropwizard:dropwizard-servlets:1.0.0
+-io.dropwizard.metrics:metrics-annotation:3.1.2
+-org.slf4j:slf4j-api:1.7.7
and
+-io.federecio:dropwizard-swagger:0.8.0-SNAPSHOT
+-io.dropwizard:dropwizard-core:1.0.0
+-io.dropwizard:dropwizard-lifecycle:1.0.0
+-org.slf4j:slf4j-api:1.7.21

[WARNING]
Dependency convergence error for com.fasterxml.jackson.core:jackson-annotations:2.7.6 paths to dependency are:
+-io.federecio:dropwizard-swagger:0.8.0-SNAPSHOT
+-io.dropwizard:dropwizard-core:1.0.0
+-io.dropwizard:dropwizard-util:1.0.0
+-com.fasterxml.jackson.core:jackson-annotations:2.7.6
and
+-io.federecio:dropwizard-swagger:0.8.0-SNAPSHOT
+-io.dropwizard:dropwizard-core:1.0.0
+-io.dropwizard:dropwizard-jackson:1.0.0
+-com.fasterxml.jackson.core:jackson-annotations:2.7.6
and
+-io.federecio:dropwizard-swagger:0.8.0-SNAPSHOT
+-io.dropwizard:dropwizard-core:1.0.0
+-io.dropwizard:dropwizard-jackson:1.0.0
+-com.fasterxml.jackson.core:jackson-databind:2.7.6
+-com.fasterxml.jackson.core:jackson-annotations:2.7.0
and
+-io.federecio:dropwizard-swagger:0.8.0-SNAPSHOT
+-io.dropwizard:dropwizard-core:1.0.0
+-io.dropwizard:dropwizard-jackson:1.0.0
+-com.fasterxml.jackson.datatype:jackson-datatype-joda:2.7.6
+-com.fasterxml.jackson.core:jackson-annotations:2.7.0
and
+-io.federecio:dropwizard-swagger:0.8.0-SNAPSHOT
+-io.dropwizard:dropwizard-core:1.0.0
+-io.dropwizard:dropwizard-jersey:1.0.0
+-com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider:2.7.6
+-com.fasterxml.jackson.module:jackson-module-jaxb-annotations:2.7.6
+-com.fasterxml.jackson.core:jackson-annotations:2.7.0

@jplock

jplock commented Jul 28, 2016

Copy link
Copy Markdown

I've been maintaining https://github.com/smoketurner/dropwizard-swagger which I'm planning to update to 1.0.0.

@willh

willh commented Jul 28, 2016

Copy link
Copy Markdown
Author

Ah fantastic - I'll take a look at integrating with this instead. I'm using dropwizard-swagger in a sample service (https://github.com/KainosSoftwareLtd/sample-dropwizard-service) that I'd like to upgrade to Dropwizard 1.0.0 so this would be really useful.

@epugh

epugh commented Aug 3, 2016

Copy link
Copy Markdown

Thanks @jplock for taking over maintenance... I'm going to check out your fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants