Skip to content

Change to use io swagger 1.5.3#67

Open
wakandan wants to merge 5 commits into
federecio:masterfrom
vforce:change-to-use-io-swagger-1.5.3
Open

Change to use io swagger 1.5.3#67
wakandan wants to merge 5 commits into
federecio:masterfrom
vforce:change-to-use-io-swagger-1.5.3

Conversation

@wakandan

Copy link
Copy Markdown

In swagger 1.5.3 they added a form to try out json body for post request, very useful

image

Please note the use of this project version 0.7.1 instead of 0.7.1-SNAPSHOT. I'm not very familiar with how maven version is managed in open source project, so please instruct me how to do it properly. Thanks

@jplock

jplock commented Aug 21, 2015

Copy link
Copy Markdown

@wakandan I'd switch back those version changes. This project uses the maven-release-plugin which handles incrementing the versions in the pom.xml files automatically whenever a new release is created.

@jplock

jplock commented Aug 21, 2015

Copy link
Copy Markdown

Merging this in will fix #66 and #63. Can you please merge this in @federecio and create a new release?

@wakandan

Copy link
Copy Markdown
Author

@jplock ah I didn't know about that. I was testing it using my local maven cache. I just need to change the version of dropwizard-swagger to 0.7.1-SNAPSHOT right?

@jplock

jplock commented Aug 22, 2015

Copy link
Copy Markdown

@wakandan yes correct, just set the dropwizard-swagger package back to 0.7.1-SNAPSHOT

@wakandan

Copy link
Copy Markdown
Author

@jplock done

@wakandan

Copy link
Copy Markdown
Author

@jplock also reverted the version of dropwizard-junit to SNAPSHOT in federecio/dropwizard-junit#7

@jplock

jplock commented Aug 22, 2015

Copy link
Copy Markdown

Looks great, thanks!

@wakandan

Copy link
Copy Markdown
Author

let's merge so that we can update from mvn guys 👯

@edwardsb

Copy link
Copy Markdown

When I run maven compile target I see this:

The POM for io.federecio:dropwizard-junit:jar:0.7 is missing, no dependency information available

And I don't see version 0.7 out on maven, only 0.6. Am I missing something? Tests fail because of this missing dependency.

@wakandan

Copy link
Copy Markdown
Author

@edwardsb 0.7 have not been published yet. There's also a pr for dropwizard-junit waiting to be merged -_-

@edwardsb

Copy link
Copy Markdown

oh alright now I see that. Thanks for all your help

@wakandan

Copy link
Copy Markdown
Author

@edwardsb you can try to clone the repo and install it locally. Then you can use 0.7 version...

@jplock

jplock commented Aug 26, 2015

Copy link
Copy Markdown

@wakandan Just fyi, but dropwizard 0.8.4 should be showing up in Maven Central later tonight. Would you mind upgrading this PR to use that latest version?

@cuzz22000

Copy link
Copy Markdown

@wakandan My PR #66 was submitted to fix #65 upgrading to io.swagger v1.5.0 was the result. Can you update the unit test so coverage for Optional is included?

@jplock

jplock commented Sep 1, 2015

Copy link
Copy Markdown

I've forked this repo to https://github.com/smoketurner/dropwizard-swagger and plan to publish it to maven central under the "com.smoketurner" groupId if anyone is interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants