Skip to content

Exclusion in POM dependency#17

Open
marcelstoer wants to merge 2 commits into
federecio:masterfrom
marcelstoer:master
Open

Exclusion in POM dependency#17
marcelstoer wants to merge 2 commits into
federecio:masterfrom
marcelstoer:master

Conversation

@marcelstoer

Copy link
Copy Markdown

IMO it'd be wise to instruct users to exclude any io.dropwizard dependencies from the io.federecio:dropwizard-swagger dependency because they have an explicit non-transitive Dropwizard dependency anyway. That way one can avoid clashes between different versions.

@federecio

Copy link
Copy Markdown
Owner

Yeah. At one point I had all dropwizard dependencies with "provided" because most likely the user will explicitly declare DW dependencies. I don't remember why I changed that.

Asking the users to exclude transitive DW dependencies when using this project seems a bit awkward. Maybe we should just mark DW dependencies with "provided" scope.

What do you think?

@marcelstoer

Copy link
Copy Markdown
Author

Asking the users to exclude transitive DW dependencies when using this project seems a bit awkward. Maybe we should just mark DW dependencies with "provided" scope.

Yes, thought about that, too. Just don't know if that'd make development more cumbersome for you. Don't think so, though.

@chmodas

chmodas commented Apr 24, 2015

Copy link
Copy Markdown
Contributor

@federecio, as the shade plugin still throws warnings, should we revisit this "poll". I wouldn't mind doing the work myself and I most definitely vote in favor of having the DW dependencies provided.

@salimane

Copy link
Copy Markdown

👍

@jplock

jplock commented Nov 12, 2015

Copy link
Copy Markdown

I don't think this version is being maintained any longer. I've forked this version and started pushing builds to maven central at https://github.com/smoketurner/dropwizard-swagger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants