Firebase integration#301
Open
TDimuth wants to merge 3 commits into
Open
Conversation
Feature submit new card
Comment on lines
+1
to
+6
| REACT_APP_API_KEY=AIzaSyBoO1cF3m--z1OKJUNaflL5drrTA0aebaE | ||
| REACT_APP_AUTH_DOMIAN=dear-diary-thusara-9535b.firebaseapp.com | ||
| REACT_APP_PROJECT_ID=dear-diary-thusara-9535b | ||
| REACT_APP_STORAGE_BUCKET=dear-diary-thusara-9535b.appspot.com | ||
| REACT_APP_SENDER_ID=458518884342 | ||
| REACT_APP_APP_ID=1:458518884342:web:9b1c0526c179fbf82c21d7 |
Contributor
There was a problem hiding this comment.
don't commit env values
| }; | ||
| dispatch(addCard(newDiaryEntry)); | ||
|
|
||
| const docRef = await addDoc(collection(db, "cards"), newDiaryEntry); |
Contributor
There was a problem hiding this comment.
don't call APIs directly from the UI file, use saga to handle API calls
| dispatch(addCard(newDiaryEntry)); | ||
|
|
||
| const docRef = await addDoc(collection(db, "cards"), newDiaryEntry); | ||
| console.log("Document written with ID: ", docRef.id); |
Contributor
There was a problem hiding this comment.
remove unwanted logs
| const dispatch = useDispatch(); | ||
|
|
||
| useEffect(() => { | ||
| const unsubscribe = onSnapshot(query(collection(db, 'cards')), (snapShot) => { |
| // https://firebase.google.com/docs/web/setup#available-libraries | ||
|
|
||
| // Your web app's Firebase configuration | ||
| console.log(process.env.REACT_APP_API_KEY) |
shamal-iroshan
suggested changes
Oct 5, 2023
shamal-iroshan
left a comment
shamal-iroshan
left a comment
Contributor
There was a problem hiding this comment.
fix commented things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.