fix(tables): Handle None events in recovery process #657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
_slurp_changelogsinfaust/faust/tables/recovery.pymethod in the recovery process doesn't properly handle None events that can occasionally be received from the changelog queue. When a None event is encountered, the code attempts to process it, which leads to errors since None doesn't have the expected attributes and methods.Solution
This PR adds a simple check at the beginning of event processing to detect and skip None events. The implementation:
Benefits
Testing
Tested in a production environment with Kafka where None events were occasionally being received from the changelog queue. The fix successfully prevents errors and maintains stable operation.