Conversation
Signed-off-by: Yujong Lee <yujonglee.dev@gmail.com>
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote-storybook canceled.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| pub use hypr_analytics::*; | ||
|
|
||
| pub type ManagedState = hypr_analytics::AnalyticsClient; | ||
| pub type ManagedState = hypr_analytics::AnalyticsService; |
There was a problem hiding this comment.
Flag plugin breaks: managed state type changed
Medium Severity
The Tauri managed state type changed from AnalyticsClient to AnalyticsService, but the plugins/flag plugin still declares pub type ManagedState = hypr_analytics::AnalyticsClient and calls self.manager.state::<ManagedState>() in get_posthog_flag. Since only AnalyticsService is now managed, any code path reaching a Posthog-backed feature flag will trigger a runtime panic. Currently no features use FlagStrategy::Posthog, so this is latent but structurally broken.


AnalyticsRuntimetrait tocrates/analyticswithenrich,distinct_id,is_disabled,set_disabledAnalyticsServicewrapper that delegates enrichment/gating to the runtimeTauriAnalyticsRuntimeinplugins/analyticswith desktop-specific enrichment and store-backed disabled stateext.rsto delegate entirely toAnalyticsService